Are there any plans or existing work toward a Drupal 8 version of the module?
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 7.x-8.x.patch | 233.42 KB | Jaesin |
Are there any plans or existing work toward a Drupal 8 version of the module?
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 7.x-8.x.patch | 233.42 KB | Jaesin |
Comments
Comment #2
jyokum commentedNone of the groups I work with are heading to D8 for a while so I have not started a D8 version yet
Comment #3
jyokum commentedComment #4
ksenzeeThis is still an active issue, correct? Or is there a Drupal 8 version now somewhere?
Comment #5
jyokum commentedI have no plans to create a D8 version but can leave this open in the event someone wants to contribute some time to it.
Comment #6
doucouredave commentedI want to contribute to the D8 version.
Comment #7
mccrodp commentedComment #8
Jaesin commentedWIP: Been working on some D8 code over here:
https://github.com/Jaesin/marketo_ma/tree/8.x-1.x
Comment #9
Jaesin commentedIt would be nice to get a 8.x-1.x branch started.
Comment #10
rolodmonkey commented@Jaesin: It looks like the plan is to create a 7.x-2.x branch with support for the REST API and then create the D8 branch off of that.
https://www.drupal.org/node/2744087
Does your patch take that into account?
Comment #11
Jaesin commentedNo, I believe this patch was created before that happened.
Comment #12
rolodmonkey commented@jyokum, @Jaesin: How would you like to handle this? Should we integrate the 7.x-2.x changes into the existing fork, or should we start over again with the 7.x-2.x branch?
Comment #13
Jaesin commentedThere isn't yet a 7.x-2.x branch that has been pushed as far as I can see. That said, the 8.x version is obviously a complete re-write.
I did switch to a tableselect for the enabled fields selection though. https://github.com/Jaesin/marketo_ma
We should get a 7.x-2.x branch and an 8.x-?.x branch in the repo so others can test and contribute.
Comment #14
rolodmonkey commented@jyokum: What would it take to make those branches? Can I help in any way?
Comment #15
jyokum commentedI'll have the branch created in the next couple of hours. Wrapping up module update hooks and clearing out the last references to soap.
Comment #16
jyokum commented7.x-2.x branch has been cut.
Comment #17
Jaesin commentedIf you create a 8.x branch on GH, I can create a pull request.
It would be great to get others involved in d8 testing and development.
Comment #18
rolodmonkey commentedYes, I am waiting eagerly to help out.
Comment #19
jyokum commentedI created an 8.x branch from 7.x-2.x and pushed to Github. If you'd prefer I create it from @Jaesin's patch let me know and I'll recreate it.
https://github.com/MarketoMA/marketo_ma/tree/8.x-1.x
Are any of you interested in being an 8.x maintainer? I'm may play around with D8 but have plans to invest much time with it.
Comment #20
rolodmonkey commentedI would be willing to be a maintainer.
Comment #21
Jaesin commentedMy branch is downstream from 7.x-1.x, I could merge in 7.x-2.x but it might be kind of pointless since most files have been replaced with classes anyway.
Comment #22
rolodmonkey commentedComment #23
rolodmonkey commented@jyokum: Could I get permission to push to your repository?
Comment #24
jyokum commented@RoloDMonkey you should have an invite to the GitHub repo and push access to 8.x-1.x if I set it up correctly
Comment #25
rolodmonkey commented@jyokum, @Jaesin just issued a pull request that puts my work to shame. I have reviewed it and would like your feedback.
https://github.com/MarketoMA/marketo_ma/pull/2
Also, some projects keep the same minor version number when moving from D7 to D8. Since this is based on 7.x-2.x should this branch be 8.x-2.x instead of 8.x-1.x?
Comment #26
jyokum commentedThanks to @Jaesin and @RoloDMonkey for the work here. 8.x-2.x dev branch is in place now.
For reference: https://github.com/MarketoMA/marketo_ma/pull/2
Comment #27
gg4 commentedIs there a plan to move the code from this project back d.o at some point soon?
Comment #28
rolodmonkey commented@bonus The code that was approved for this issue is available:
https://www.drupal.org/project/marketo_ma
Comment #29
gg4 commented@RoloDMonkey -- awesome. Will development continue on GH or be moved to d.o. at some point as well?
Comment #30
Ritvi commentedHi, I am newbie to D8, I already have a project, having custom contact module, I wanted to implement Marketo MA to that, coz when i am enabling the contact module, my custom contact page distorts. PLease help, giving me a lead, as to how to solve the problem. Thanks