Are there any plans or existing work toward a Drupal 8 version of the module?

CommentFileSizeAuthor
#9 7.x-8.x.patch233.42 KBJaesin

Comments

ksenzee created an issue. See original summary.

jyokum’s picture

None of the groups I work with are heading to D8 for a while so I have not started a D8 version yet

jyokum’s picture

Status: Active » Closed (fixed)
ksenzee’s picture

Status: Closed (fixed) » Active

This is still an active issue, correct? Or is there a Drupal 8 version now somewhere?

jyokum’s picture

I have no plans to create a D8 version but can leave this open in the event someone wants to contribute some time to it.

doucouredave’s picture

I want to contribute to the D8 version.

mccrodp’s picture

Jaesin’s picture

WIP: Been working on some D8 code over here:

https://github.com/Jaesin/marketo_ma/tree/8.x-1.x

Jaesin’s picture

Status: Active » Needs review
StatusFileSize
new233.42 KB

It would be nice to get a 8.x-1.x branch started.

rolodmonkey’s picture

@Jaesin: It looks like the plan is to create a 7.x-2.x branch with support for the REST API and then create the D8 branch off of that.

https://www.drupal.org/node/2744087

Does your patch take that into account?

Jaesin’s picture

No, I believe this patch was created before that happened.

rolodmonkey’s picture

@jyokum, @Jaesin: How would you like to handle this? Should we integrate the 7.x-2.x changes into the existing fork, or should we start over again with the 7.x-2.x branch?

Jaesin’s picture

There isn't yet a 7.x-2.x branch that has been pushed as far as I can see. That said, the 8.x version is obviously a complete re-write.

I did switch to a tableselect for the enabled fields selection though. https://github.com/Jaesin/marketo_ma

We should get a 7.x-2.x branch and an 8.x-?.x branch in the repo so others can test and contribute.

rolodmonkey’s picture

@jyokum: What would it take to make those branches? Can I help in any way?

jyokum’s picture

I'll have the branch created in the next couple of hours. Wrapping up module update hooks and clearing out the last references to soap.

jyokum’s picture

7.x-2.x branch has been cut.

Jaesin’s picture

If you create a 8.x branch on GH, I can create a pull request.

It would be great to get others involved in d8 testing and development.

rolodmonkey’s picture

Yes, I am waiting eagerly to help out.

jyokum’s picture

I created an 8.x branch from 7.x-2.x and pushed to Github. If you'd prefer I create it from @Jaesin's patch let me know and I'll recreate it.
https://github.com/MarketoMA/marketo_ma/tree/8.x-1.x

Are any of you interested in being an 8.x maintainer? I'm may play around with D8 but have plans to invest much time with it.

rolodmonkey’s picture

I would be willing to be a maintainer.

Jaesin’s picture

My branch is downstream from 7.x-1.x, I could merge in 7.x-2.x but it might be kind of pointless since most files have been replaced with classes anyway.

rolodmonkey’s picture

Status: Needs review » Needs work
rolodmonkey’s picture

@jyokum: Could I get permission to push to your repository?

jyokum’s picture

@RoloDMonkey you should have an invite to the GitHub repo and push access to 8.x-1.x if I set it up correctly

rolodmonkey’s picture

@jyokum, @Jaesin just issued a pull request that puts my work to shame. I have reviewed it and would like your feedback.

https://github.com/MarketoMA/marketo_ma/pull/2

Also, some projects keep the same minor version number when moving from D7 to D8. Since this is based on 7.x-2.x should this branch be 8.x-2.x instead of 8.x-1.x?

jyokum’s picture

Assigned: Unassigned » jyokum
Status: Needs work » Closed (fixed)

Thanks to @Jaesin and @RoloDMonkey for the work here. 8.x-2.x dev branch is in place now.

For reference: https://github.com/MarketoMA/marketo_ma/pull/2

gg4’s picture

Is there a plan to move the code from this project back d.o at some point soon?

rolodmonkey’s picture

@bonus The code that was approved for this issue is available:

https://www.drupal.org/project/marketo_ma

gg4’s picture

@RoloDMonkey -- awesome. Will development continue on GH or be moved to d.o. at some point as well?

Ritvi’s picture

Hi, I am newbie to D8, I already have a project, having custom contact module, I wanted to implement Marketo MA to that, coz when i am enabling the contact module, my custom contact page distorts. PLease help, giving me a lead, as to how to solve the problem. Thanks