I am attempting to upgrade DevShop to use Aegir 3.

Having problems installing.

I think it might be related to a circular dependency between hosting.module and the other hosting_*.modules.

hosting.info:

Name = Hosting
description = Allow this Drupal site to deploy hosted sites.
package = Hosting
core = 7.x

dependencies[] = views
dependencies[] = views_bulk_operations
dependencies[] = hosting_task
dependencies[] = hosting_client
dependencies[] = hosting_db_server
dependencies[] = hosting_package
dependencies[] = hosting_platform
dependencies[] = hosting_site
dependencies[] = hosting_web_server

hosting_site.info:

name = Sites
description = Allow Aegir to manage of hosted sites.
package = Hosting
dependencies[] = hosting
dependencies[] = hosting_client

The only reason hosting.info should have dependencies on all of these would be to enable them when hosting.module is enabled... however that is already handled by the hostmaster.info install profile.

I think we should remove these dependencies from hosting.info.

Patch coming...

CommentFileSizeAuthor
#2 2610122-circular-dependencies.patch536 bytesJon Pugh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Jon Pugh created an issue. See original summary.

Jon Pugh’s picture

  • Jon Pugh committed 37b8b7d on 2610122-circular-dependencies
    Issue #2610122 by Jon Pugh: Circular Dependencies between hosting and...
Jon Pugh’s picture

Status: Active » Needs review

Pushed a new branch with this: 2610122-circular-dependencies

DevShop has had this patch on it's hosting modules for months, so I'm 100% confident it works great....

https://github.com/opendevshop/devmaster/commit/56a0b71daf34fea390b0b9ad...

ergonlogic’s picture

Status: Needs review » Reviewed & tested by the community

I'm all for removing these dependencies. +1

  • Jon Pugh committed 37b8b7d on 7.x-3.x
    Issue #2610122 by Jon Pugh: Circular Dependencies between hosting and...
helmo’s picture

Status: Reviewed & tested by the community » Fixed

Merged

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.