Needs work
Project:
Drupal 8 Contrib Porting Tracker
Version:
8.x-0.x-dev
Component:
Module
Priority:
Minor
Category:
Plan
Assigned:
Unassigned
Reporter:
Created:
3 Nov 2015 at 02:17 UTC
Updated:
20 Jan 2020 at 22:02 UTC
Jump to comment: Most recent
Comments
Comment #2
mgiffordComment #3
kristen polComment #4
kristen polComment #5
gstout commentedPretty please
Comment #6
decipheredJust a quick note to say that I have started on an D8 port and will commit the progress so far at the end of the day and link to the git repository.
I need this for a client, so I will be progressing as quick as possible.
Comment #7
decipheredFirst commit made. Still a lot of work to do before the module is usable, but a large chunk of the functionality has been ported across into Drupal 8 plugin system (with a new plugin type ResponsiveMenus created).
You can follow development at https://github.com/Realityloop/responsive_menus.
I expect to have a usable release (even in a basic form) before the end of the week.
Comment #8
awasson commented@Deciphered: Awesome. Thanks for jumping on this.
Comment #9
decipheredNp. Additional commit coming in the next hour, not finished yet, but a lot of progress has been made (including having PoC'd that the simple menu can work in D8).
I have also removed all the Context based integration for the moment as it's not yet applicable.
Comment #10
decipheredSecond commit pushed. Plugins are 90% ported (still need to deal with the libraries and settings storage systems) and as such the administration UI is about 99% complete.
Should only take one more round of work, but I won't be able to do that till after the weekend.
The Simple menu can be used with the current work by simply changing the default value for the jQuery selector on the following line: https://github.com/Realityloop/responsive_menus/blob/8.x-1.x/src/Plugin/...
However I would suggest that unless you know what you are doing not to use this port at the stage as it is not yet ready.
Comment #11
hoporr commentedJust tried this, and it works! (when you change that one line in the code with your selector)
Thanks!
looking forward to when you can save the configs.
Comment #12
decipheredLatest commit allows you to actually save the plugin (menu style) settings, making it usable now. Limitation is that only the 'Simple expanding' menu style is currently usable, the other styles will start to be added in the next commit. PRs welcome though.
Comment #13
liakoni commentedIs there any progress for the other styles to be usable in Drupal 8?
Comment #14
decipheredI haven't had time for any more development, and am unlikely to in the near future unless it's a requirement from a client, however the code is sitting there for anyone who wishes to get involved. I'll even review PRs made to my repo, or feel free to make your fork the theoretical canonical source.
Comment #15
jwjoshuawalker commentedWow, how am I just discovering this.
@Deciphered, may I use your code as the 8.x branch here on d.o?
Nice work!
Comment #16
deciphered@drastik Absolutely, that is the intent. I'd appreciate credit to my company (Realityloop) in the Supporting Organisations section, but it's not mandatory, I'll leave up to you.
Comment #17
jwjoshuawalker commented@Deciphered,
I'll put you as the author of the commit.
On the project page, I'll put the credit line in as so, let me know if you want it worded any differently (or what URL "Realityloop" should link to):
Supporting Organizations
Drupal 8 port thanks to Realityloop.
Comment #18
deciphered@drastik, If you just use the built in Organisations aspect of the project page, link it to the Realityloop Organisation. Otherwise, http://realityloop.com.
Thanks, appreciated.
Comment #19
snlnz commented@drastik and @Deciphered, what happened to the D8 port ending up here on D.O? Was there a problem?
Comment #20
mmjvb commentedWith a dev release, Status should be Needs work.
Comment #21
renguer0 commentedSo, no responsive menus in D8 at the moment?
Comment #22
jwjoshuawalker commented@renguer0
The dev branch should be fine to use.