D8 port: Configure and display site books [#2597804]

Confirguration

Supply a checklist of all books on the site under "Books to include"
Supply a checkbox option to show all book pages expanded
Should only be visible when the book module is enabled.

Display

Show all selected books, including expanding the book tree to show all pages if that option was selected.

Topics for discussion

I'm nervous about opening up a can of worms with these, but just so they're on the radar:

Should the list of books be sortable, the way the menus are?
Should we keep the "Books on [site name]" description? Personally I don't like how it's just there in the D7 version, but I suppose we could make it a configuration option for people who want intro text for each section.

Comment	File	Size	Author
#4	site_map_books-2597804-4.patch	517 bytes	akalata
#2	Screen Shot 2015-10-27 at 5.39.19 PM.png	15.53 KB	akalata
#2	Screen Shot 2015-10-27 at 5.38.12 PM.png	43.2 KB	akalata

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

20 October 2015 at 23:08

akalata created an issue. See original summary.

Comment #2

akalata CreditAttribution: akalata commented 27 October 2015 at 22:49

Issue summary:

View changes

File	Size
Screen Shot 2015-10-27 at 5.38.12 PM.png	43.2 KB
Screen Shot 2015-10-27 at 5.39.19 PM.png	15.53 KB

Comment #3

akalata CreditAttribution: akalata commented 27 October 2015 at 23:12

Currently works when books are expanded, but when not expanding books I see the following:

Symfony\Component\Routing\Exception\RouteNotFoundException: Route "node.view" does not exist. in Drupal\Core\Routing\RouteProvider->getRouteByName() (line 193 of core/lib/Drupal/Core/Routing/RouteProvider.php).

Comment #4

akalata CreditAttribution: akalata commented 28 October 2015 at 00:08

Status:

Active

» Needs review

File	Size
site_map_books-2597804-4.patch	517 bytes

Comment #5

28 October 2015 at 00:40

Nafes committed 5a01e21 on 8.x-1.x authored by akalata

Issue #2597804 by akalata: D8 port: Configure and display site books

Comment #6

Nafes CreditAttribution: Nafes as a volunteer commented 28 October 2015 at 00:45

@akalata, great! The patch fixes the exception. Thank you again. If you have nothing to add here, please close the issue as Fixed.

Comment #7

akalata CreditAttribution: akalata commented 28 October 2015 at 00:47

For the immediate issue of "getting it working", I think we're good here. Wondering what your thoughts are on the "Topics for discussion" in the issue summary?

Comment #8

Nafes CreditAttribution: Nafes as a volunteer commented 28 October 2015 at 01:03

Status:

Needs review

» Fixed

I agree about "getting it working". This is the main priority for now. We can open separate issues for discussion topics, especially for books descriptions, and fix them later in alpha/beta version of the module. Worms can be placed into separate can(s) :) Setting issue as Fixed.