Closed (duplicate)
Project:
Chaos Tool Suite (ctools)
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
20 Oct 2015 at 07:14 UTC
Updated:
5 Feb 2018 at 04:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
madhavvyas commentedFixed coding standard for the includes/context-task-handler.inc
Comment #3
snehi commentedHi Madhav,
There are trailing spaces in the patch. Can you pleae look into this.
line numbers are :
20
61
71
96
99
116
129
140
173
189
216
Comment #4
anil280988 commentedRemoved Whitespaces.
Comment #5
anil280988 commentedComment #6
nicrodgersSome good changes in here, but a couple of issues with the patch in #4:
This change has (unintentionally?) changed the meaning here. I don't think this change should be included. We just need to re-wrap the comment to 80-chars.
We've lost the mention of 'default function' here.
This could be re-wrapped to a single line that fits within 80 chars.
@return tag is missing.
This re-writing doesn't make much sense.
Comment #7
rajeshwari10 commentedUnable to apply patch. Patch needs to be reroll.
Comment #8
rajeshwari10 commentedCoding standard issues are fixed as per said in #6.
Comment #9
snehi commentedCan we have the interdiff please?
Comment #10
rajeshwari10 commentedAdding interdiff.
Comment #11
tiago.urbano commentedLine exceeds 80 characters; contains 84 characters.
Doc comment short description must be on a single line, further text should be a separate paragraph.
Comment #12
tiago.urbano commentedRevised and did more coding standards
Comment #14
tiago.urbano commentedSolved
Comment #15
renatog commentedHi guys.
I applied the patch and #14 makes sense for me.
RTBC
Thank you very much @tiago.urbano
Regards
Comment #17
geek-merlinComment #18
joelpittetWith the release of the latest stable, most of this was picked off with phpcbf before the release.
Comment #19
joelpittetNot sure there will get anything out of a reroll, closing this one.