Comments

madhavvyas created an issue. See original summary.

madhavvyas’s picture

Status: Active » Needs review
StatusFileSize
new8.42 KB

Fixed coding standard for the includes/context-task-handler.inc

snehi’s picture

Status: Needs review » Needs work

Hi Madhav,
There are trailing spaces in the patch. Can you pleae look into this.
line numbers are :
20
61
71
96
99
116
129
140
173
189
216

anil280988’s picture

StatusFileSize
new8.41 KB

Removed Whitespaces.

anil280988’s picture

Status: Needs work » Needs review
nicrodgers’s picture

Assigned: madhavvyas » Unassigned
Status: Needs review » Needs work

Some good changes in here, but a couple of issues with the patch in #4:

  1. +++ b/includes/context-task-handler.inc
    @@ -16,24 +16,22 @@
    - * Render a context type task handler given a list of handlers
    - * attached to a type.
    + * Render a context type task handler.
      *
    - * @param $task
    + * It will give a list of handlers attached to a type.
    

    This change has (unintentionally?) changed the meaning here. I don't think this change should be included. We just need to re-wrap the comment to 80-chars.

  2. +++ b/includes/context-task-handler.inc
    @@ -222,7 +223,7 @@ function ctools_context_handler_render_handler($task, $subtask, $handler, $conte
    - * Default function to provide contextual link for a task as defined by the handler.
    + * To provide contextual link for a task as defined by the handler.
    

    We've lost the mention of 'default function' here.

  3. +++ b/includes/context-task-handler.inc
    @@ -259,17 +262,19 @@ function ctools_task_handler_default_contextual_link($handler, $plugin, $context
      *   TRUE if these contexts match the selection rules. NULL or FALSE
      *   otherwise.
    

    This could be re-wrapped to a single line that fits within 80 chars.

  4. +++ b/includes/context-task-handler.inc
    @@ -288,11 +293,11 @@ function ctools_context_handler_select($handler, $contexts) {
    - * @param $handler
    + * @param object $handler
      *   The handler to be checked.
    

    @return tag is missing.

  5. +++ b/includes/context-task-handler.inc
    @@ -364,11 +369,12 @@ function ctools_context_handler_get_all_contexts($task, $subtask, $handler) {
    - * Create an object suitable for use with the context system that kind of
    - * expects things in a certain, kind of clunky format.
    + * Create an object suitable for use with the context system.
    + *
    + * That kind of object expects things in a certain, kind of clunky format.
    

    This re-writing doesn't make much sense.

rajeshwari10’s picture

Assigned: Unassigned » rajeshwari10
Issue tags: +Needs reroll

Unable to apply patch. Patch needs to be reroll.

rajeshwari10’s picture

Status: Needs work » Needs review
StatusFileSize
new8.49 KB

Coding standard issues are fixed as per said in #6.

snehi’s picture

Can we have the interdiff please?

rajeshwari10’s picture

StatusFileSize
new2.22 KB

Adding interdiff.

tiago.urbano’s picture

Status: Needs review » Needs work
Issue tags: +ciandt-contrib
StatusFileSize
new15.64 KB

Comment

Line exceeds 80 characters; contains 84 characters.
Doc comment short description must be on a single line, further text should be a separate paragraph.

tiago.urbano’s picture

Assigned: rajeshwari10 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new9.63 KB

Revised and did more coding standards

Status: Needs review » Needs work

The last submitted patch, 12: ctool_codingstandard-2596997-12.patch, failed testing. View results

tiago.urbano’s picture

Status: Needs work » Needs review
StatusFileSize
new9.62 KB

Solved

renatog’s picture

Status: Needs review » Reviewed & tested by the community

Hi guys.

I applied the patch and #14 makes sense for me.

RTBC

Thank you very much @tiago.urbano

Regards

The last submitted patch, 8: revise_coding_standard-2596997-8.patch, failed testing. View results

geek-merlin’s picture

joelpittet’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

With the release of the latest stable, most of this was picked off with phpcbf before the release.

joelpittet’s picture

Status: Needs work » Closed (duplicate)

Not sure there will get anything out of a reroll, closing this one.