CommentFileSizeAuthor
#7 update-code-as-per-drupal-coding-standard-2593171-7.patch7.23 KBajaybmishra
#5 ctools-n2593171-5.patch17.07 KBdamienmckenna
#2 ctool_codingstandard-2593171.patch7.31 KBmadhavvyas

Comments

madhavvyas created an issue. See original summary.

madhavvyas’s picture

madhavvyas commented
StatusFileSize
new ctool_codingstandard-2593171.patch7.31 KB

Fixed coding standard issue includes/cache.inc, includes/cleanstring.inc, includes/collapsible.inc

madhavvyas’s picture

madhavvyas commented
Status: Active » Needs review
laxman.ghavte’s picture

laxman.ghavte commented
Status: Needs review » Reviewed & tested by the community

Code formatting looks good to me.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new ctools-n2593171-5.patch17.07 KB

Sorry, but this needed work.

chris matthews’s picture

chris matthews commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

The 3 year old patch in #5 to cache.inc, cleanstring.inc and theme.inc does not apply to the latest ctools 7.x-1.x-dev and (if applicable) needs a reroll.

ajaybmishra’s picture

ajaybmishra commented
StatusFileSize
new update-code-as-per-drupal-coding-standard-2593171-7.patch7.23 KB

@madhavvyas - I found that you missed some more coding standards in these three files and also found that some changes in your patch was not required according to Drupal coding standard so not included those changes.

Find attached patch and review it.

ajaybmishra’s picture

ajaybmishra commented
Status: Needs work » Needs review

Changing status to Needs Review.

Status: Needs review » Needs work

The last submitted patch, 7: update-code-as-per-drupal-coding-standard-2593171-7.patch, failed testing. View results

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Closed (won't fix)

I understand how fun these patches can be to do, but the fact is they are very disruptive to other patches in the queue that are actually fixing problems and I'm going to close this so people don't continue to work on them because I'm reluctant to commit them.

Feel free to improve the standards on existing patches, if they don't change the patch size, they are welcome fixes.