Comments

madhavvyas created an issue. See original summary.

madhavvyas’s picture

StatusFileSize
new6.58 KB

Fixed coding standard issue includes/ajax.inc, includes/action-links.theme.inc

madhavvyas’s picture

Status: Active » Needs review
madhavvyas’s picture

madhavvyas’s picture

snehi’s picture

Status: Needs review » Reviewed & tested by the community

Worked for me.
This is gone for RTBC now. Thanks for the patch.

damienmckenna’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new7 KB

There were a few small things that needed work.

chris matthews’s picture

Status: Needs review » Needs work
Issue tags: +Needs reroll

The 3 year old patch in #7 to action-links.theme.inc does not apply to the latest ctools 7.x-1.x-dev and (if applicable) needs a reroll.

Checking patch includes/action-links.theme.inc...
Hunk #1 succeeded at 6 (offset 1 line).
Hunk #2 succeeded at 18 (offset 1 line).
error: while searching for:
  }

  return '<ul class="action-links">' . $links . '</ul>';
}
error: patch failed: includes/action-links.theme.inc:30
error: includes/action-links.theme.inc: patch does not apply
Checking patch includes/ajax.inc...
error: while searching for:
<?php

// Set this so we can tell that the file has been included at some point.
define('CTOOLS_AJAX_INCLUDED', 1);

/**
 * @file
 * Extend core AJAX with some of our own stuff.
 */

/**
 * Render an image as a button link. This will automatically apply an AJAX class
 * to the link and add the appropriate javascript to make this happen.
 *
 * @param $image
 *   The path to an image to use that will be sent to theme('image') for rendering.
 * @param $dest
 *   The destination of the link.
 * @param $alt
 *   The alt text of the link.
 * @param $class
 *   Any class to apply to the link. @todo this should be a options array.
 */
function ctools_ajax_image_button($image, $dest, $alt, $class = '') {

error: patch failed: includes/ajax.inc:1
error: includes/ajax.inc: patch does not apply
chris matthews’s picture

Status: Needs work » Closed (outdated)
Issue tags: -Needs reroll