Add extra mail config

This seems like a reasonable strategy.

Instead of hacking webform, install your own submit handler into the form to save the extra settings. They will be saved to the database (I think). I'm not sure what else "extra" is used for without reading the code.

No, I don't see this going into webform, especially with Drupal hooks make it reasonable to accomplish without modifying webform itself.

@DanChadwick
I was looking at doing the same thing. Extra is used to store the "Email components" and other things according to the column description.

The rest of webform allows you to modify the form and submit the data the way you describe through hooks (and update the extra column). The issue with the email hook is that the "$email" variable gets created and submitted to database in the same submit handler. Giving no way to modify. In addition the only way that "extra" gets into the variable is through here:

<?php
/**
 * Submit handler for webform_email_edit_form().
 */
function webform_email_edit_form_submit($form, &$form_state) {
  // Ensure a webform record exists.
  $node = $form['#node'];
  webform_ensure_record($node);

  // Remove duplicate email To: addresses.
  $form_state['values']['email_custom'] = implode(',', array_unique(array_map('trim', explode(',', $form_state['values']['email_custom']))));

  // Merge the e-mail, name, address, and subject options into single values.
  $email = array(
    'eid' => $form_state['values']['eid'],
    'nid' => $node->nid,
  );

  foreach (array('email', 'from_name', 'from_address', 'subject') as $field) {
    $option = $form_state['values'][$field . '_option'];
    if ($option == 'default') {
      $email[$field] = 'default';
    }
    else {
      $email[$field] = $form_state['values'][$field . '_' . $option];

      // Merge the email mapping(s) into single value(s)
      $cid = $form_state['values'][$field . '_' . $option];
      if (is_numeric($cid) && isset($form_state['values'][$field . '_mapping'][$cid])) {
        $email['extra'][$field . '_mapping'] = $form_state['values'][$field . '_mapping'][$cid]; <--- only place extra gets built!!!!!!!!!!!!
      }
    }
  }
...........
}
?>

So the only way that you can really get your data in is to have a module declare a submit handler that gets fired AFTER webforms and do another write to the database. Which isn't this one of the powers of the hooks? To modify so we have less db writes/reads?

The code I am using to bypass this until the above patch of #1 gets committed is:

<?php
/**
 * Additional submit callback for form webform_component_edit_form.
 */
function mymodule_form_webform_email_edit_form_submit(&$form, &$form_state) {

  if(!empty($form_state['values']['myfield'])) {
    $eid = $form_state['values']['eid'];
    $email = array(
      'eid' => $eid,
      'nid' => $form['#node']->nid,
      'extra' => empty($form['#node']->webform['emails'][$eid]['extra']) ? FALSE : $form['#node']->webform['emails'][$eid]['extra'],
    );

    foreach ($form_state['values']['myfield'] as $item => $value) {
      $email['extra'][$item] = $value;
    }

    $email['extra'] = empty($email['extra']) ? '' : serialize($email['extra']);
    $success = drupal_write_record('webform_emails', $email, array('nid', 'eid'));
  }
}
?>

Notice that I am doing an additional write AND having to create a little bit of processing code just to get this in unscathed.

So please commit the above patch +1+1 it has very little effect and makes the email form work similar to the rest of webform's edit forms.

Reroll

The 3 year old patch in #7 still applies cleanly to the latest 7.x-4.x-dev and would be a nice feature to have.

Checking patch includes/webform.emails.inc...
Hunk #1 succeeded at 554 (offset 9 lines).
Applied patch includes/webform.emails.inc cleanly.

Drupal 7 is no longer supported. If this applies to a supported version, please re-open.