Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Follow-up to #2577785-3: Remove PlaceholderTrait
protected static function placeholderFormat($string, array $args) {
$arguments is more consistant,
and placeholderFormat needs a better name.
Proposed resolution
Rename placeholderFormat() to replacePlaceholders() and the argument $args to $arguments
(note will conflict with #2580505: Improve FormattableMarkup documentation, which is fine, one or the other can be rerolled depending on which goes in first.)
Remaining tasks
Task | Novice task? | Contributor instructions | Complete? |
---|---|---|---|
Create a patch | Instructions | ||
Update the patch to incorporate feedback from reviews (include an interdiff) | Instructions | ||
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards | Instructions |
User interface changes
No
API changes
Yes
Data model changes
No
Comment | File | Size | Author |
---|---|---|---|
#12 | interdiff-2580525-7-12.txt | 2.47 KB | marvin_B8 |
#12 | 2580525-12.patch | 13.63 KB | marvin_B8 |
#5 | 2580525-5.patch | 14.6 KB | marvin_B8 |
#2 | 2580525-2.patch | 14.14 KB | YesCT |
Comments
Comment #2
YesCT CreditAttribution: YesCT commentedused "refactor" to do this (hopefully means didn't miss anything that way)
checked that changes didn't cause any 80 char re-wrapping needed.
Comment #3
YesCT CreditAttribution: YesCT commentedComment #4
YesCT CreditAttribution: YesCT commentedcause of where we are in release cycle, this needs to keep the old one around as a wrapper, and be marked deprecated so there are no BC API breaks.
Comment #5
marvin_B8 CreditAttribution: marvin_B8 as a volunteer and at comm-press commentedis that ok ?
Comment #6
dawehnerHere is a little bit of whitespace
Given that we deal with a protected method I think its okay to not have a BC layer
Comment #7
marvin_B8 CreditAttribution: marvin_B8 as a volunteer and at comm-press commentedok, i have remove the bc layer.
Comment #8
dawehnerCool, thank you!
Comment #10
marvin_B8 CreditAttribution: marvin_B8 as a volunteer and at comm-press commentedComment #12
marvin_B8 CreditAttribution: marvin_B8 as a volunteer and at comm-press commentedComment #14
marvin_B8 CreditAttribution: marvin_B8 as a volunteer and at comm-press commentedComment #15
dawehnerThis is a question, given that this protected method is used in more places, I'm curious whether we should keep a quick BC layer?
Comment #27
smustgrave CreditAttribution: smustgrave at Mobomo commentedhttps://www.drupal.org/project/drupal/issues/2580505 appears closer then this so postponing this for now. Once the other lands this can be rerolled (which is needed)