Problem/Motivation

As per #2489406: Put the exposed form in a block should be a checkbox., we need to discuss an improved wording for this form.

Proposed resolution

Could be :

If set, removes exposed form from view. Creates disabled block on blocks page.

Remaining tasks

User interface changes

API changes

Data model changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pguillard created an issue. See original summary.

pguillard’s picture

Issue summary: View changes
pguillard’s picture

Version: 8.0.x-dev » 8.1.x-dev
rosinegrean’s picture

Assigned: Unassigned » rosinegrean
bendev’s picture

I propose "Manage exposed form as a block"
"If set" is implicit since this is a checkbox
Blocks are managed on block page...

What do you think?

bendev’s picture

by the way What I read in the interface is "Exposed form in block" yes or no

vdanielpop’s picture

The current title is "Exposed form in block" and its description is "Allow the exposed form to appear in a block in a block instead of the view." .
In my opinion that is explicit enough, is this the one you want improved wording for ?

vdanielpop’s picture

Assigned: rosinegrean » Unassigned
snehi’s picture

Assigned: Unassigned » snehi
Status: Active » Needs review
FileSize
766 bytes

Please review attached patch.

bendev’s picture

I find the title more explicit than the description.
The description should complete the title with useful information. What do we need to know on top of "Exposed form in block"

snehi’s picture

@bendev can you please suggest ?

bendev’s picture

I didn't suggest because I didn't come to a good proposal neither...
sorry will think again about it

cilefen’s picture

Title: Change description on from "Display exposed form as a block" » Change description on form "Display exposed form as a block"
cilefen’s picture

Issue summary: View changes
cilefen’s picture

+++ b/core/modules/views/src/Plugin/views/display/DisplayPluginBase.php
@@ -1331,7 +1331,7 @@ public function optionsSummary(&$categories, &$options) {
         'value' => $this->getOption('exposed_block') ? t('Yes') : t('No'),
-        'desc' => t('Allow the exposed form to appear in a block instead of the view.'),
+        'desc' => t('This removes exposed form from view and creates a block of exposed form.'),
       );

I realize this is work-in-progress but as-is this sentence should read "This removes the exposed form from the view and creates a block of the exposed form.".

snehi’s picture

As @cilefen said changes done.

mikeker’s picture

snehi’s picture

Assigned: snehi » Unassigned
Status: Needs review » Closed (duplicate)

Marking as duplicate. But i think credit should be gone to everyone whosoever worked in this issue.