Problem/Motivation

There is no Drupal 8 version of Doubleclick for Publishers (DFP).

Proposed resolution

Refactor Doubleclick for Publishers (DFP) for Drupal 8

Remaining tasks

  1. Open an 8.x branch
  2. Create issues for Drupal 8 version refactoring
  3. Release rolling dev version

User interface changes

Probably. :)

API changes

A Lot. :)

Data model changes

Blocks work differently in Drupal 8. Config API exists. Custom data should be a custom entity rather than a database table.

CommentFileSizeAuthor
#5 2579123.5.patch256.8 KBalexpott

Comments

davidwbarratt created an issue. See original summary.

jyoti.singh’s picture

jyoti.singh commented

Has anybody started porting DFP module in Drupal 8.I am working on a project and i need this module.I have started customising it but it would be a great help to me if somebody assist me with it.

bleen’s picture

bleen commented

Nope ... You looking to take it on? I'm happy to open an 8.x branch and make you a maintainer

Sorry ... I thought the comment was from David (Original poster) whom I know. Since I'm not familiar with your code (Etc...) I would want to see your code and where you are going with the moule before asking you to be a maintainer, but i am happy to take a look and work with you on it if you want to get started on an 8.x version

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

I've started a port - it's on GitHub just to have a place to push to... https://github.com/chapter-three/dfp

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2579123.5.patch256.8 KB

Here's a patch based on the github repo. I'm going to commit this to a new 8.1.x branch and fix this issue. The only features the patch does not have that the 7.x version has is the ability to inject custom javascript on the page, to determine a tag's targeting from visible taxonomy terms, and to do out-of-page ads.

Status: Needs review » Needs work

The last submitted patch, 5: 2579123.5.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Fixed

Obviously this doesn't pass Drupal 7 testing :). I've pushed the new branch and enabled the dev release - it should show up soon...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.