SafeMarkup::format() is deprecated, so we shouldn't use it anymore.

CommentFileSizeAuthor
#4 2578645-4--core_changes.patch50.41 KBdrunken monkey
#2 2578645-2--SafeMarkup_format_calls.patch31.3 KBdrunken monkey

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 2578645-2--SafeMarkup_format_calls.patch31.3 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2578645-2--SafeMarkup_format_calls.patch, failed testing.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Title: Remove calls to SafeMarkup::format() » Adapt to latest Core changes
Status: Needs work » Needs review
StatusFileSize
new 2578645-4--core_changes.patch50.41 KB

Seems our tests just got broken anyways, and then there's the KernelTestBase change also deprecating some of our code – so, just widening the scope of this issue.
Tests passed fine locally, after same sweat and tears.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Ah, seems the old test bot will not test patches while the branch is broken, and cannot be overridden like the new one.
So, just committing, and hoping for the best.

  • drunken monkey committed 4be8cca on 8.x-1.x 
    Issue #2578645 by drunken monkey: Adapted the code to the latest Core...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.