[D7] NProgress

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Dynamic or static links and HTML in translatable strings
$output .= '<li>' . t('Install the !libraries module.', array('!libraries' => l(t('Libraries API'), 'http://drupal.org/project/libraries'))) . '</li>';

/**
 * Implements hook_init().
 */
function nprogress_page_alter(&$page) {

There are some bugs in nprogress.js.

I have typeof $.fn.NProgress = undefined, all the time, and nprogres doesn't work.
It's first time I see Drupal behavior inside if statement.

Another thing I'm not sure about
$(document).
I'd prefer to use
$(document, context).
but I not sure is it fit right for this situation.

http://cgit.drupalcode.org/sandbox-Alons-2155421/tree/js/ajax_page_load.js

I think there are other ways to download plugin, rather then using git clone.
You can recieve zipped version https://github.com/rstacruz/nprogress/archive/master.zip

It looks very nice now. I even forget about that I've installed it, but I saw blue line, when I start to use devel_generate batch.

I have few more questions:
In file nprogress.js

if (typeof NProgress === 'function') {
  return;
}

I've test this and typeof NProgress was undefined or object, but never equal to function. And I don't understand the reason why it's there, maybe you could provide few comments in code.

The second one. I don't like that it is hasn't UI ability to disable library attach and it's attached to each page by default. But I think it is more like feature request, neither bug.

The last one: could you provide installation instruction in page description for non drush users.

I found some issues in your js files, there is some minor mistakes in coding standard.

@pranavbabbar: I think you forgot to change the status. Is this now RTBC after your review or are there application blockers left?

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements

Coding style & Drupal API usage

1. (*) Unless it is important to group this module with others, you should remove the package declaration in the .info file. From the documentation: "In general, this property should only be used by large multi-module packages, or by modules meant to extend these packages, such as Fields, Views, Commerce, Organic Groups, and the like."
2. Describe a little more clearly what the module does in the .module file.
3. Use tabs and not spaces.
4. Provide a list of modules that use ajax calls for testing.

This review uses the Project Application Review Template.

I heard wrong somewhere else. You are right, the coding standards prove your point about the spaces, although I (and probably half of the programming community) strongly disagree with this sentiment. Two spaces is not enough room to visually distinguish the beginning of a new logical block imho. Plus, dealing with spaces in editors is a pain. Just the way I feel though. Also disregard #1. You were right to put your module in that package. It is a standard container that many UI programs use.

I tried to install the module by only copying NProgress module folder to the all modules folder (without NProgress library). After the module has been enabled I did not see a message about the missing library on the modules list page (/admin/modules). I go to the Status page (/admin/reports/status) and see error message "NProgress module requires NProgress.js library." but do not understand how I can install the library.

I go to the Help pages (/admin/help/nprogress) and see two messages.

1. Install the Libraries API module.
2. Download the NProgress plugin and upload the entire folder to sites/all/libraries/nprogress. When installed correctly, the file nprogress.js should be available at sites/all/libraries/nprogress/.

If I can see message about needing Libraries API it means that NProgress module and Libraries API are already installed. If Libraries API module is not already installed, I can not see this message.

NProgress plugin page returns a 404 error.

So, I can not use NProgress library and the module.

UPD: Vendor url from nprogress_libraries_info() http://cornel.bopp-art.com/nprogress/ returns a 404 error also.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.