Follow-up to #2274195: Decide ESLint config

For some reason .eslintrc and .eslintignore are in the root directory, but they are only checking core files. To be consistent with phprs.xml, it should be moved to the core folder.

CommentFileSizeAuthor
#2 i2575541-2.patch693 bytesattiks
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 114,310 pass(es). View
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

attiks created an issue. See original summary.

attiks’s picture

Status: Active » Needs review
FileSize
693 bytes
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 114,310 pass(es). View

Moved both files and updated the .eslintignore file.

nod_’s picture

I want module to be checked to being in root means contrib desn't have to duplicate the config all the time.

attiks’s picture

We need to find a way to run this on the core directory, excluding all contrib, so testbot can add it. Eventually testbot will start running for contrib as well, but they need to be able to alter the excluded dirs i think.

For the moment the .eslintignore contains very specific core directories, so it does not make sense to put it in the core directory.

nod_’s picture

oh for the testbot that's an easy fixeslint core/

the ignore file don't cascade like the config files so it's a bit tricky.

attiks’s picture

or we move the .eslintignore to the core folder and run eslint in that folder?

nod_’s picture

that works

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

anoopjohn’s picture

What was finally decided on this?

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

kwoxer’s picture

Status: Needs review » Needs work

Needs re-roll. Patch fails at Drupal 8.4.

hass’s picture

Does this really make sense? Currently this config is inherited to contrib modules. I only extended the part needed for my module. With this change the rules no longer exists for contrib and are not applied there. I think this is not good for quality of modules running QA tests on d.o.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

pinoniq’s picture

Hey, just leaving this comment here: https://www.drupal.org/project/drupal/issues/2815077 this moved to the airbnb-config breaking all our eslint builds in custom themes.

This because the root eslintrc.json file was automatically being included. I personally don't get why this got committed with no bc.

As long as there is no package.json in the root, you can not simply add .eslint configurations that require certain dependencies.
For instance, the eslint-plugin-react module is required, which seems weird if you don't use react.

For me there are two solutions:
* include a package.json in the root so people know what packages to install
* don't include the .eslintrc.json file in the root