Problem/Motivation

Ensuring that all classes that are loaded before the apc classloader is activated are in the classmap.

To reproduce, add a breakpoint or print in composer/Classloader.php::findFile() after the classMap check.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 classmap-2575175-6.patch1.57 KBberdir
#4 classmap-2575175-4.patch2.32 KBberdir
#2 classmap-2575175-2.patch1.1 KBberdir

Comments

Berdir created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new classmap-2575175-2.patch1.1 KB

AccountInterface was missing and two symfony classes, which had to have been there before but we probably missed them?

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work

These are the list of classes we load:

    [160] => ComposerAutoloaderInitDrupal8
    [161] => Composer\Autoload\ClassLoader
    [162] => Drupal
    [163] => Drupal\Core\DrupalKernel
    [164] => Symfony\Component\HttpFoundation\Request
    [165] => Symfony\Component\HttpFoundation\ParameterBag
    [166] => Symfony\Component\HttpFoundation\FileBag
    [167] => Symfony\Component\HttpFoundation\ServerBag
    [168] => Symfony\Component\HttpFoundation\HeaderBag
    [169] => Drupal\Component\Utility\Unicode
    [170] => Drupal\Core\Site\Settings
    [171] => Drupal\Core\Database\Database

These are the list of interfaces:

    [16] => Drupal\Core\DrupalKernelInterface
    [17] => Symfony\Component\HttpKernel\HttpKernelInterface
    [18] => Symfony\Component\DependencyInjection\ContainerAwareInterface
    [19] => Symfony\Component\HttpKernel\TerminableInterface
    [20] => Drupal\Core\Session\AccountInterface

and we don't load any trait.

According to this list, we should remove the HttpKernel from Composer.php, we removed the timer from DrupalKernel,

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new classmap-2575175-4.patch2.32 KB

Removed those two, also kept them in alphabetic order.

Status: Needs review » Needs work

The last submitted patch, 4: classmap-2575175-4.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new classmap-2575175-6.patch1.57 KB

Messed up my patch.

The last submitted patch, 4: classmap-2575175-4.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Closed (outdated)
Related issues: +#3204539: Optimized classmap is out of date

This is no longer relevant, we are on a different major version of Symfony and I opened #3204539: Optimized classmap is out of date before I found this.