Cannot add a new taxonomy tag with "Tagged with" when creating a new View

Trying to reproduce this. The only place I see where I can add a tag to the View is after creation and then choosing 'Edit view name/description' and then adding a tag.

I don't see the error the @gease reported but I do get a javascript error when entering text in the tag field:

TypeError: undefined is not a function (evaluating 'suggestions.indexOf(tagged[i])')

Found the reason for the javascript error I got. Don't know if it solves the original reported error, since I still can't reproduce that.

Ajax bug, so needs manual testing (right?).

Problem was that autocomplete expects a numeric array and views_ui returned an associative array. It would seem that autocomplete.js has a function for dealing with this, well according to the doc block, anyway, because the function doesn't appear to do what it says in the doc block...

/**
     * Transforms the data object into an array and update autocomplete results.
     *
     * @param {object} data
     */
    function sourceCallbackHandler(data) {
      autocomplete.cache[elementId][term] = data;

      // Send the new string array of terms to the jQuery UI list.
      showSuggestions(data);
    }

But sending a numeric array fixes it.

.

Added a test that tests if a numeric array is returned.

+++ b/core/modules/views_ui/src/Controller/ViewsUIController.php
@@ -192,7 +192,7 @@ public function autocompleteTag(Request $request) {
+        if (!in_array($tag, $matches)) $matches[] = $tag;

This is not the code style we use

Fixed code style.

+++ b/core/modules/views_ui/src/Controller/ViewsUIController.php
@@ -192,7 +192,9 @@ public function autocompleteTag(Request $request) {
       $tag = $view->get('tag');
       if ($tag && strpos($tag, $string) === 0) {
-        $matches[$tag] = $tag;
+        if (!in_array($tag, $matches)) {
+          $matches[] = $tag;
+        }
         if (count($matches) >= 10) {
           break;
         }

I'm a bit confused about that. Don't we wether need to adapt it to look something like

        $matches[] = array('value' => $category, 'label' => Html::escape($category));

, see \Drupal\block\Controller\CategoryAutocompleteController::autocomplete

Well, it worked with just a string, but yeah that format looks much better. Thanks for pointing me in the right direction.

Updated the fix like suggested in #12 and updated the tests to match.

With this fixed you run into a new issue, #2579531: Can only see a small number of tags when adding a tag to a view.

New tag can't be added on Add new view page
a) On Add new view page (/structure/views/add) fill "View name" and "Tagged with" fields
b) Save it
Actual result: There are no entities matching %tag%.
Expected result: New view with entered tag is saved.

@timisoreana Ah thank you! Now I get what the original issue is about. It has nothing to do with tagging the View! Updated the issue title and summary to better reflect what this is about and moved my fix to a new issue #2618034: Adding tag to a View gives an error

So need a new patch here ...

@gease, Thanks for reporting this issue. We rely on issue reports like this one to resolve bugs and improve Drupal core.

I tested this on 9.2.x and was not able to reproduce this error. I followed the steps given in the Issue Summary and #16. I used devel to generate content with tags. I was able to create a view, using the autocomplete field to select the tag. The update preview in the view correctly listed several node. I was also able to enter multiple tags when creating the view. There were no errors displayed or in the log.

Therefore, closing as cannot reproduce. If you are experiencing this problem reopen the issue, by setting the status to 'Active', and provide complete steps to reproduce the issue (starting from "Install Drupal core").

Thanks!

Should be 9.2.x