Missing property name: $element['title']

CommentFileSizeAuthor
#14 2572349-14.patch3.43 KBaerozeppelin
#14 interdiff-2572349-11-14.txt2.24 KBaerozeppelin
#11 2572349-11.patch3.38 KBnevergone
#8 2572349-8.patch3.38 KBaerozeppelin
#8 2572349-8-test-only-fail.patch2.16 KBaerozeppelin
#8 interdiff-2572349-2-8.txt3.37 KBaerozeppelin
#2 2572349-missing_fapi_property_D7.patch913 bytesnevergone
#2 2572349-missing_fapi_property_D8.patch1.07 KBnevergone

Comments

nevergone created an issue. See original summary.

nevergone’s picture

nevergone
Primary language Hungarian
commented
StatusFileSize
new 2572349-missing_fapi_property_D8.patch1.07 KB
new 2572349-missing_fapi_property_D7.patch913 bytes
nevergone’s picture

nevergone
Primary language Hungarian
commented
Status: Active » Needs review

Please needs review.

Status: Needs review » Needs work

The last submitted patch, 2: 2572349-missing_fapi_property_D7.patch, failed testing.

chx’s picture

chx commented
Issue tags: +Needs tests

Don't we have a test for fieldSettingsForm? If we do, it needs amending, if we don't we need one. Also the ! was just changed to @ and noone caught this. Very nice.

chx’s picture

chx commented
Parent issue: » #2571943: Remove !placeholder in file.module

The last submitted patch, 2: 2572349-missing_fapi_property_D7.patch, failed testing.

aerozeppelin’s picture

aerozeppelin commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2572349-2-8.txt3.37 KB
new 2572349-8-test-only-fail.patch2.16 KB
new 2572349-8.patch3.38 KB

Test to check valid values are entered in 'Maximum upload size' text field.

The last submitted patch, 8: 2572349-8-test-only-fail.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

nevergone’s picture

nevergone
Primary language Hungarian
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 2572349-11.patch3.38 KB

#8 is tested and works well!
The patch is re-rolled, but not modified.

nevergone’s picture

nevergone
Primary language Hungarian
commented
Issue tags: +Needs backport to D7
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: -Needs tests
  1. The issue summary needs an update because this is fixing more than what the issue summary details. Also the fix might need more testing - see point 2. 
  2. +++ b/core/modules/file/src/Plugin/Field/FieldType/FileItem.php
@@ -244,8 +244,9 @@ public static function validateExtensions($element, FormStateInterface $form_sta
+    $max_size = Bytes::toInt($element['#value']);
+    if (!empty($element['#value']) && $max_size == 0) {

    I think we should test setting to 0 which should be allowed. As I think it'll mean unlimited... this is a bit weird because 0 MB is not allowed... perhaps needs more thinking and tests. 

  3. +++ b/core/modules/file/src/Tests/FileFieldDisplayTest.php
@@ -165,4 +165,35 @@ function testDescToggle() {
+  function testFileFieldSettings() {

    Should have a scope modifier - ie. public - yes the rest of the class is missing them - but we shouldn't introduce new issues. 

  4. +++ b/core/modules/file/src/Tests/FileFieldDisplayTest.php
@@ -165,4 +165,35 @@ function testDescToggle() {
+    $field = $this->createFileField($field_name, 'node', $type_name, $field_storage_settings, $field_settings, $widget_settings);

    No need for the $field = - the $field variable is not used. 

  5. +++ b/core/modules/file/src/Tests/FileFieldDisplayTest.php
@@ -165,4 +165,35 @@ function testDescToggle() {
+    foreach($edit as $i){
...
+    foreach($edit_1 as $i){

    Needs a space after the foreach and before the {

  6. Wrt to the backport to D7 - the policy is to now create an issue against the 7.x branch and not use the same issue. Ideally that issue exists before this one is committed.
aerozeppelin’s picture

aerozeppelin commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2572349-11-14.txt2.24 KB
new 2572349-14.patch3.43 KB

Updates from #13.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

quietone’s picture

quietone commented
Version: 8.9.x-dev » 9.2.x-dev
Status: Needs review » Needs work
Issue tags: +Needs issue summary update

Lets get an Issue Summary update before any thing else is done here. See write an issue summary for an existing issue.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs work » Postponed (maintainer needs more info)

Based on the request for an IS update in #22

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Postponed (maintainer needs more info) » Closed (outdated)
Issue tags: +Bug Smash Initiative

Since there hasn't been a follow up to #22 in 2 years going to close this out for now.

If still a valid bug though please reopen, updating the issue summary.

Thanks.

quietone’s picture

quietone commented

@smustgrave, I think some research on the issue should be done before closing it. There are patches here which we can use to determine if this is fixed

This time I looked at the code in the patch. It was originally changing ['title'] to ['#title'] in the field instance settings. That change now exists in FileItem.php. The later patches contain other changes out of scope with the issue summary, as pointed out in #8. The new test is testing the max filesize and that is now done in FieldFieldValidateTest.php. Based on that I agree this can be closed as outdated.