The module is very poorly written in terms of coding standards, need to fix this as per Drupal coding standards.

Comments

swarad07 created an issue. See original summary.

swarad07’s picture

Title: Make the better_messages.module file coder module compatible » Make the better_messages module coder module compatible
Priority: Major » Critical
Issue summary: View changes
swarad07’s picture

Status: Active » Needs review
StatusFileSize
new9.29 KB

Fixing the coder warnings and errors so that the code of 7.x-1.x branch is now compatible to coder.

devd’s picture

Version: 7.x-1.x-dev » 7.x-1.0-alpha1
Assigned: swarad07 » Unassigned
Issue tags: +Coding standards
StatusFileSize
new15.3 KB

Fixed all the coding standards which are in the .module/.in/.js file.

  1. Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized
  2. Use an indent of 2 spaces, with no tabs [style_no_tabs]
  3. There should be no trailing spaces [style_trailing_spaces]
  4. File: @file block missing (Drupal Docs) [comment_docblock_file]
  5. Comment should be read "Implements hook_foo()." [comment_comment_implementation]
    The correct use of the string is 'e.g.,' (with a comma after it). However, for clarity, consider changing 'e.g.' to 'for example,'. [comment_comment_eg]
devd’s picture

StatusFileSize
new15.4 KB

Added the module author email in docblock.

swarad07’s picture

Issue summary: View changes
swarad07’s picture

Version: 7.x-1.0-alpha1 » 7.x-1.x-dev
Status: Needs review » Needs work

Please check the Patch creation guidelines, your file naming conventions are wrong. https://www.drupal.org/node/707484

Secondly, I created the issue to highlight the problem in the main code flow in the development branch, changing to correct version.

devd’s picture

Priority: Critical » Normal
Status: Needs work » Needs review
StatusFileSize
new44.82 KB

Thanks ,

To acknowledge me.

The attached patch have the following fixes.

  • Use st() instead of t() in hook_install().
  • The $text argument to l() should be enclosed within t() so that it is translatable.
  • Menu item titles and descriptions should NOT be enclosed within t().
  • CSS standards.

Coding standards can not be critical any more. So I am downgrade the priority as normal.

swarad07’s picture

Thanks @devd for helping out with the patch.

dishabhadra’s picture

Status: Needs review » Reviewed & tested by the community
Pradnya Pingat’s picture

Assigned: Unassigned » Pradnya Pingat
Status: Reviewed & tested by the community » Needs work
swarad07’s picture

@pradnya.pingat: I think you marked this as needs work by mistake, is there an issue you have found out?

Pradnya Pingat’s picture

Assigned: Pradnya Pingat » Unassigned
Status: Needs work » Reviewed & tested by the community

changed it by mistake.

le72’s picture

Status: Reviewed & tested by the community » Closed (outdated)