Closed (outdated)
Project:
Better Messages
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
12 Sep 2015 at 10:36 UTC
Updated:
30 Jan 2022 at 12:10 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
swarad07Comment #3
swarad07Fixing the coder warnings and errors so that the code of 7.x-1.x branch is now compatible to coder.
Comment #4
devd commentedFixed all the coding standards which are in the .module/.in/.js file.
The correct use of the string is 'e.g.,' (with a comma after it). However, for clarity, consider changing 'e.g.' to 'for example,'. [comment_comment_eg]
Comment #5
devd commentedAdded the module author email in docblock.
Comment #6
swarad07Comment #7
swarad07Please check the Patch creation guidelines, your file naming conventions are wrong. https://www.drupal.org/node/707484
Secondly, I created the issue to highlight the problem in the main code flow in the development branch, changing to correct version.
Comment #8
devd commentedThanks ,
To acknowledge me.
The attached patch have the following fixes.
Coding standards can not be critical any more. So I am downgrade the priority as normal.
Comment #9
swarad07Thanks @devd for helping out with the patch.
Comment #10
dishabhadra commentedComment #11
Pradnya Pingat commentedComment #12
swarad07@pradnya.pingat: I think you marked this as needs work by mistake, is there an issue you have found out?
Comment #13
Pradnya Pingat commentedchanged it by mistake.
Comment #14
le72