Needs review
Project:
Commerce Core
Version:
7.x-1.x-dev
Component:
Developer experience
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
4 Sep 2015 at 09:01 UTC
Updated:
15 Dec 2015 at 19:43 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
joachim commentedComment #3
torgospizzaThis seems reasonable enough. Would like to get some more eyes on it.
Comment #4
mglamanUpdating tags. This requires some good old fashioned manual testing :)
Comment #5
torgospizzaThis does work for me, all system messages remain intact when dealing with Ajax panes in the form.
Comment #6
mglamanSnippet from views/includes/ajax.inc. We're not checking if in AJAX, which it seems to be the issue here. The way error messages are handled by the form outside of AJAX should be working fine.
My one wonder would be: what about other panes that do AJAX, will it steal their messages? this might be an issue at core's message storage, but worthy question.
Comment #7
joelpittetLikely will steal any message sent with
drupal_set_message(). Though I'm not quite sure which would win. I have my messages in panels_everywhere pane.