Problem/Motivation

meh

Proposed resolution

* Don't store the same temp file
* Clean it up

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 entityfiletest_fails-2562453-6.patch1.99 KBneclimdul
#2 2562453-2.patch1.27 KBdawehner

Comments

dawehner created an issue. See original summary.

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new 2562453-2.patch1.27 KB

Let's see what the bot thinks

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

Ideally we'd test this with vfsStream -- AFAIK there is no reason it will not work in SimpleTest -- but to me this looks good enough for now.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Reviewed & tested by the community » Needs work

the test needs to be updated to reference the new file name.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

Erp :) </embarrassed>

EntityFileTest needs a lot of work in general, but @klausi is correct.

neclimdul’s picture

neclimdul
He/Him
commented
StatusFileSize
new entityfiletest_fails-2562453-6.patch1.99 KB

How about this then.

neclimdul’s picture

neclimdul
He/Him
commented
Status: Needs work » Needs review

derp, to testbot.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

yeah that is the much better approach here

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: entityfiletest_fails-2562453-6.patch, failed testing.

Status: Needs work » Needs review

phenaproxima queued 6: entityfiletest_fails-2562453-6.patch for re-testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

I suspect that may have been one of the random fails this issue is meant to fix.

I forgot to copy the test failure output -- sorry! -- but I looked before re-queueing. It was, indeed, a "cannot copy file" failure of EntityFileTest, which is what this issue is intended to fix.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Okay according to @phenaproxima #6 failed in EntityFileTest - maybe this change has made it a consistent fail ... let's see.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

So it didn't fail :( that is a shame. The problem I have is that I don't understand how the random fail is caused - this seems to be the only test that accesses this file so I'm not sure how it is failing.

neclimdul’s picture

neclimdul
He/Him
commented

That's a good point, we don't have an unlink (its own problem that this test does fix) so it wouldn't be a race condition. I've not actually seen the failure yet so I don't actually know what the trace is I was just going with the IS. This is clearly an improvement either way but we should definitely narrow down the failure if possible.

neclimdul’s picture

neclimdul
He/Him
commented

Just to clarify because dawehner asked about it IRC, we should have had an unlink before, we don't need one in this patch because we're using the simpletest site directory so its auto cleaned up for us in TestBase::restoreEnvironment().

Status: Needs review » Needs work

The last submitted patch, 6: entityfiletest_fails-2562453-6.patch, failed testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Did this just fail randomly?

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

quietone’s picture

quietone commented
Status: Needs work » Closed (outdated)

EntityFileTest was moved in #2684141: Convert migrate kernel tests to KernelTestBaseTNG to core/modules/file/tests/src/Kernel/Migrate/EntityFileTest.php. Then in #2695297: Refactor EntityFile and use process plugins instead, it was deleted. The new tests for file migrations are not listed in the meta for random test failures, #2829040: [meta] Known intermittent, random, and environment-specific test failures. And FWIW I have no memory of random failures in the file migrations. Therefor closing as outdated.

Therefore, closing as outdated. If this is incorrect reopen the issue, by setting the status to 'Active', and add a comment explaining what still needs to be done.

Thanks!