Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Tested in Bartik.
When a node is being previewed with javascript disabled, the bar containing the "Back to content editing" button is not visible.
Steps to reproduce
Proposed resolution
See #16
Remaining tasks
Patch
Review
Add screenshots
User interface changes
Before with javascript
Before without javascript
After with javascript
TBA
After without javascript
TBA
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#29 | Screenshot 2023-09-05 at 8.19.50 AM.png | 266.82 KB | Gauravvvv |
javascript-enabled.png | 104.94 KB | StryKaizer | |
javascript-disabled.png | 47.06 KB | StryKaizer |
Comments
Comment #2
StryKaizerComment #3
joelpittetComment #4
droplet CreditAttribution: droplet commentedNeeds advice from toolbar maintainers.
I believe it's also bring some benefit to #2542050: Toolbar implementation creates super annoying re-rendering.
Comment #12
nod_Still an issue
Comment #13
nod_Comment #14
pradeepjha CreditAttribution: pradeepjha at Srijan | A Material+ Company for Drupal India Association commentedDynamic padding top is added to Body tag through JS code https://git.drupalcode.org/project/drupal/-/blob/9.1.x/core/modules/tool.... When we collapse Manage button, padding-top value get changed.
So when we disable JS, toolbar menu gets hidden inside main admin menu. Because there is no padding-top or any top value applied to show it after admin menu. That's why it's not visible. Check attached screenshot.
Comment #15
poojakural CreditAttribution: poojakural as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedComment #16
droplet CreditAttribution: droplet commentedIt's pretty easy to fix.
https://git.drupalcode.org/project/drupal/-/blob/9.0.x/core/modules/node...
adding Weight to force the elements rendered after
#toolbar-administration
Furthermore,
I think
#toolbar-administration
should be set Weight to something like -99999999999 which is always on the top.Comment #17
poojakural CreditAttribution: poojakural as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedComment #18
poojakural CreditAttribution: poojakural as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedComment #23
quietone CreditAttribution: quietone at PreviousNext commentedUnassigning because this hasn't been worked on in 2years.
Comment #24
quietone CreditAttribution: quietone at PreviousNext commentedCame back to test. This is still true on Drupal 9.5.x, standard install. Updated the IS.
Comment #27
yash.rode CreditAttribution: yash.rode at Acquia commentedBartik is removed from core so, is it still a core issue?
Comment #28
smustgrave CreditAttribution: smustgrave at Mobomo commentedWill need an issue summary update but did just verify with claro that this issue is still there.
Comment #29
Gauravvvv CreditAttribution: Gauravvvv at Axelerant for Drupal India Association commentedI tried reproducing the issue with Umami and Olivero theme in Drupal 11. "Back to content editing" is visible to me, but toolbar is overlapping it. Attached screenshot for same.