Problem/Motivation

Tested in Bartik.

When a node is being previewed with javascript disabled, the bar containing the "Back to content editing" button is not visible.

Steps to reproduce

Proposed resolution

See #16

Remaining tasks

Patch
Review
Add screenshots

User interface changes

Before with javascript

Before without javascript

After with javascript
TBA

After without javascript
TBA

Data model changes

Release notes snippet

CommentFileSizeAuthor
#29 Screenshot 2023-09-05 at 8.19.50 AM.png266.82 KBgauravvvv
#14 dynamic-css.png138.73 KBpradeepjha
javascript-enabled.png104.94 KBstrykaizer
javascript-disabled.png47.06 KBstrykaizer

Comments

StryKaizer created an issue. See original summary.

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Title: Back to content bar on node preview not visible when javascript is disabled » Back to content editing bar on node preview page not visible when javascript is disabled
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Component: theme system » javascript
Issue summary: View changes
droplet’s picture

droplet commented
Component: javascript » toolbar.module
Issue tags: -theming +JavaScript

Needs advice from toolbar maintainers.

I believe it's also bring some benefit to #2542050: Toolbar implementation creates super annoying re-rendering.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 8.8.x-dev » 9.1.x-dev
Issue tags: -JavaScript +JavaScript

Still an issue

nod_’s picture

nod_
Primary language French
Location Lille
commented
Parent issue: » #3144979: [Meta] Toolbar with JavaScript disabled
pradeepjha’s picture

pradeepjha commented
StatusFileSize
new dynamic-css.png138.73 KB

Dynamic padding top is added to Body tag through JS code https://git.drupalcode.org/project/drupal/-/blob/9.1.x/core/modules/tool.... When we collapse Manage button, padding-top value get changed.

So when we disable JS, toolbar menu gets hidden inside main admin menu. Because there is no padding-top or any top value applied to show it after admin menu. That's why it's not visible. Check attached screenshot.

poojakural’s picture

poojakural commented
Assigned: Unassigned » poojakural
droplet’s picture

droplet commented

It's pretty easy to fix.

https://git.drupalcode.org/project/drupal/-/blob/9.0.x/core/modules/node...
adding Weight to force the elements rendered after #toolbar-administration

Furthermore,

I think #toolbar-administration should be set Weight to something like -99999999999 which is always on the top.

poojakural’s picture

poojakural commented
Assigned: poojakural » Unassigned
poojakural’s picture

poojakural commented
Assigned: Unassigned » poojakural

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Assigned: poojakural » Unassigned

Unassigning because this hasn't been worked on in 2years.

quietone’s picture

quietone commented
Issue summary: View changes
Issue tags: +Bug Smash Initiative

Came back to test. This is still true on Drupal 9.5.x, standard install. Updated the IS.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

yash.rode’s picture

yash.rode commented
Status: Active » Needs review

Bartik is removed from core so, is it still a core issue?

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs issue summary update

Will need an issue summary update but did just verify with claro that this issue is still there.

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new Screenshot 2023-09-05 at 8.19.50 AM.png266.82 KB

I tried reproducing the issue with Umami and Olivero theme in Drupal 11. "Back to content editing" is visible to me, but toolbar is overlapping it. Attached screenshot for same.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Needs work » Postponed

The Toolbar Module was approved for removal in #3476882: [Policy] Move Toolbar module to contrib.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3484850: [meta] Tasks to deprecate Toolbar module and the removal work in #3488828: [meta] Tasks to remove Toolbar module.

Toolbar will be moved to a contributed project before Drupal 12.0.0 is released.

quietone’s picture

quietone commented
Project: Drupal core » Toolbar
Version: main » 1.x-dev
Component: toolbar.module » Code
Status: Postponed » Needs work

Toolbar has moved to contrib