Problem/Motivation

CKEditor 4.5 added oEmbed support. Which means we mostly "just" have to decide whether we want Drupal 8 to support oEmbed or not.

Proposed resolution

TBD

Remaining tasks

Discuss

User interface changes

TBD

API changes

None.

Data model changes

None.

Comments

Wim Leers created an issue. See original summary.

yched’s picture

yched commented

The oEmbed support in recent CK, and what we could / should do with it, has been puzzling me for while.

A couple toughts :

- Native support for embedding of remote media sounds super interesting of course :-)
- Wondering about the implicit dependency on a 3rd party provider (http://iframely.com by default). That would be unusual for a core feature, and is more typically provided by contrib modules ?
- Being a CMS, we'd probably want the semantic flavor, that just stores marker tags processed & themed on output, rather than directly storing the final media HTML ?
- As a kind of "field-oriented" person ;-), I feel a bit weird having the feature natively inside text blobs and not in discrete fields, for which you need Media / Scald or whatever to provide media entities
- Once you start on the Media / Scald path, you have entity_embed as a competing way to embed media inside text blobs. Then, not clear to me how the two approaches co-exist

I'm sure the Media folks have interesting things to say about how they see oEmbed ?

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

- Native support for embedding of remote media sounds super interesting of course :-)

+1

- Wondering about the implicit dependency on a 3rd party provider (http://iframely.com by default). That would be unusual for a core feature, and is more typically provided by contrib modules ?

+1, this is my biggest concern. I've also told the CKEditor team about this, and they understand it, but that's an unfortunate downside of oEmbed…

- Being a CMS, we'd probably want the semantic flavor, that just stores marker tags processed & themed on output, rather than directly storing the final media HTML ?

+1

- As a kind of "field-oriented" person ;-), I feel a bit weird having the feature natively inside text blobs and not in discrete fields, for which you need Media / Scald or whatever to provide media entities

+1, this is the discussion we need to have first and foremost. I think it makes sense to be able to embed a Youtube video in a narrative. Not all sites actually need those to be fields. But if they're not fields, we also can't list them. (Think: a "presentation" content type that lists all videos.) This is where an interesting overlap exists between CKEditor Widgets + Entity Embed: embedding a video in the text editor should automatically update the entity field (== structured data) and just show it inline. But that's a whole undertaking.

- Once you start on the Media / Scald path, you have entity_embed as a competing way to embed media inside text blobs. Then, not clear to me how the two approaches co-exist

I should read each bullet before replying :P But obviously +1.

I'm sure the Media folks have interesting things to say about how they see oEmbed ?

+1

Thanks, @yched, for asking all the right questions! :D

yched’s picture

yched commented

I think it makes sense to be able to embed a Youtube video in a narrative. Not all sites actually need those to be fields.

Sure. I'm just wondering, when you then add a real media management solution à la Media / Scald, how those coexist with the "oEmbedded media" feature (or the oEmbedded media in existing content). Maybe that issue already exists with our "inline image" plugin currently, so not really something new ?

But if they're not fields, we also can't list them. (Think: a "presentation" content type that lists all videos.) This is where an interesting overlap exists between CKEditor Widgets + Entity Embed: embedding a video in the text editor should automatically update the entity field (== structured data) and just show it inline

True - does core's current "embed inline local image" currently keeps track of "that entity references that image" ?

Also, FWIW, scald in D7 maintains a common reference table that tracks which entity contains which media (whether in discrete reference fields or embedded in text blobs). The "medias" that are tracked are local entities with local numeric IDs, though.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

True - does core's current "embed inline local image" currently keeps track of "that entity references that image" ?

Yep. See _editor_record_file_usage() and its callers. Upload an image and you'll see its usages listed at admin/content/files. D8 has the file_usage table and uploaded images are tracked there too. oEmbed embeds always correspond to an URL, so I guess we could track those URLs in there too (although file_usage is really intended to only be used for internal (Drupal-owned) files…).

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Issue tags: +Media Initiative

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Related issues: +#2831944: Implement media source plugin for remote video via oEmbed

Adding #2831944: Implement media source plugin for remote video via oEmbed as a related issue.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Postponed » Active

Blocker is in.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

smustgrave’s picture

smustgrave commented
Status: Active » Postponed (maintainer needs more info)
Issue tags: -JavaScript +JavaScript, +stale-issue-cleanup

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Postponed (maintainer needs more info) » Closed (duplicate)

Closing as duplicate, we added OEmbed support for remote media entities in #2831944: Implement media source plugin for remote video via oEmbed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.