Create a new field called Twitter Prefix to prep-end a Twiiter share text

CommentFileSizeAuthor
#11 add_a_twitter_prefix-2558441-11.patch3.23 KBnitesh sethia
#9 add_a_twitter_prefix-2558441-9.patch3.23 KBnitesh sethia
#8 ShareThis.png362.33 KBsowmiya.S
#6 add-twitter-prefix-field-2558441-5.patch3.85 KBe.hadidi
#4 add-twiiter-prefix-field-2558441-4.patch3.85 KBe.hadidi
#3 add-twitter-prefix-field-2558441-3.patch3.11 KBe.hadidi
#2 add-twitter-prefix-field-2558441-1.patch3.32 KBe.hadidi

Comments

e.hadidi created an issue. See original summary.

e.hadidi’s picture

e.hadidi commented
StatusFileSize
new add-twitter-prefix-field-2558441-1.patch3.32 KB
e.hadidi’s picture

e.hadidi commented
StatusFileSize
new add-twitter-prefix-field-2558441-3.patch3.11 KB

there is no need to check if there is a default value for twitter_prefix field! So I removed the statement that check that.

e.hadidi’s picture

e.hadidi commented
StatusFileSize
new add-twiiter-prefix-field-2558441-4.patch3.85 KB

Add if/elseif statements to include all cases.

e.hadidi’s picture

e.hadidi commented
e.hadidi’s picture

e.hadidi commented
StatusFileSize
new add-twitter-prefix-field-2558441-5.patch3.85 KB

fixed some indentation issues according to drupal standards.

e.hadidi’s picture

e.hadidi commented
Status: Active » Needs review
sowmiya.S’s picture

sowmiya.S commented
StatusFileSize
new ShareThis.png362.33 KB

I have worked in drupal 7.x-2.10 & 7.x-2.11 versions using https://simplytest.me. But it shows like error occurred while patching the project.

nitesh sethia’s picture

nitesh sethia commented
StatusFileSize
new add_a_twitter_prefix-2558441-9.patch3.23 KB

This patch would create a new field called Twitter Prefix on the configuration page to prepend some text before the title of the content before sharing the content on Twitter.

Status: Needs review » Needs work

The last submitted patch, 9: add_a_twitter_prefix-2558441-9.patch, failed testing.

nitesh sethia’s picture

nitesh sethia commented
Status: Needs work » Needs review
StatusFileSize
new add_a_twitter_prefix-2558441-11.patch3.23 KB

This patch would create a new field called Twitter Prefix on the configuration page to prepend some text before the title of the content before sharing the content on Twitter.

nitesh sethia’s picture

nitesh sethia commented
navneet0693’s picture

navneet0693 commented
Status: Needs review » Reviewed & tested by the community

Working fine. Thanks for patch @Nitesh.

purushotam.rai’s picture

purushotam.rai commented
Status: Reviewed & tested by the community » Fixed

Thanks all for your efforts. We appreciate all your inputs. Committed the code to 7.x-2.x-dev branch and marking issue as fixed as of now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.