Clean install with Drupal 7.39, CTools 1.9 / latest dev and Rules 2.9.
Steps to recreate:
- Create a Rule for "Content is viewed". I chose to redirect to a user page. Rule works fine.
- Enable Panels and Page Manager. Create a variant and add a Pane with full node content. Rule is now broken and nothing is logged for Rules.
- Disable variant and Rule works fine again.
This is a severe issue and has completely broken my site.
| Comment | File | Size | Author |
|---|---|---|---|
| #18 | ctools-panel-node-view-broken-2556253-18.patch | 659 bytes | akashkumar07 |
| #6 | ctools-panel-node-view-broken-2556253-5.patch | 976 bytes | alesr |
| #4 | ctools-panel-node-view-broken-2556253-4.patch | 1.08 KB | alesr |
Comments
Comment #2
niallmurphy-ie commentedOk, narrowed down the change..
In 1.17 ctools\page_manager\plugins\tasks\node_view.inc
In 1.19 ctools\page_manager\plugins\tasks\node_view.inc
I have no idea what any of it means but is the change necessary? Swapping the file seems to fix the problem and cause no ill effects in limited testing.. Would love a response on whether or not this was part of the security fix. Thanks.
Comment #3
alesr commentedThis issue is not displaying my default images on node view panel page.
Here's the diff:
Comment #4
alesr commentedPatch that solves this issue.
$default_output = node_page_view($node);Moved to the top of the page_manager_node_view_page() function.
Comment #6
alesr commentedFixed path in patch #5.
Comment #7
niallmurphy-ie commentedWill this be committed to the next release?
Comment #8
Jeroen94 commentedI'm having the same problem on my website. Applying patch #6 solved it!
Comment #9
Jeroen94 commentedComment #10
niallmurphy-ie commentedHi, this fix didn't get included in the 1.10 release.
Is this a ctools, rules or panels issue? Thanks.
Comment #11
rivimeyI'm trying to help japerry get ctools-1.11 out the door.
The change that appears to have caused this is 2437773. I am concerned that simply reverting that change (which is essentially what this patch does) may fix this issue but break something else, so I have commented on that thread asking for assistance.
If others here could comment that would be helpful too.
Comment #12
rivimeyComment #13
niallmurphy-ie commentedThanks for looking into it.. I may as well be looking at Chinese when it comes to the big modules.
Comment #14
japerryI too am worried about what this will do. Marking needs review until a few more ctools users get a look at it.
Comment #15
niallmurphy-ie commented7.x-1.12 still doesn't address this issue.
Comment #16
alesr commentedStumbled upon this issue after years writing the patch for it.
This time I had to add js after a specific node type is viewed.
If you are using Panels after Ctools version 7.x-1.8, hook_node_view() is not called when viewing node panel page. It was called before this Display Suite issue came in and the patch that caused all the trouble was committed without proper testing: https://www.drupal.org/project/ctools/issues/2437773
Now we have to call hook_ctools_render_alter() to get similar functionality but it's not the most effective way to do it.
The question is... Is this regression problem going to be fixed?
Comment #17
chris matthews commentedThe 3 year old patch in #6 does not apply to the latest ctools 7.x-1.x-dev.
Comment #18
akashkumar07 commented#6 Rerolled
Comment #19
abryenton@gmail.com commented#18 works great for me using ctools-7.x-1.x-dev