I refactored the two related issues and combined them into a single patch as we needed both issues resolved.

The "Menu links do not support 2+ links with same menu_name/link_path":

  • Older menu exports will import their menu items but the feature will be in overridden state till they are updated
  • Importing the new style menu links will not remove older menu items that should have been "replaced". This is because matching is only done on a unique ID and never by path or title. Menu items will need to be deleted manually.
  • Menu items that are added by things like panels or views should not be in code in both a menu link feature and the panel / view feature. Before, the menu link was smart enough to match by path or title but now it only matches by unique ID.
CommentFileSizeAuthor
#5 features-link-uuid-and-export-by-unique-id-2556151-5-D7.patch21.81 KBmattsqd
#3 features-link-uuid-and-export-by-unique-id-2556151-3-D7.patch21.7 KBmattsqd
#2 features-link-uuid-and-export-by-unique-id-2556151-2-D7.patch18.31 KBmattsqd

Comments

mattsqd created an issue. See original summary.

mattsqd’s picture

mattsqd commented
StatusFileSize
new features-link-uuid-and-export-by-unique-id-2556151-2-D7.patch18.31 KB
mattsqd’s picture

mattsqd commented
StatusFileSize
new features-link-uuid-and-export-by-unique-id-2556151-3-D7.patch21.7 KB

Updated to allow upgrading already exported menu items as well as handling parent identifiers better.

Status: Needs review » Needs work

The last submitted patch, 3: features-link-uuid-and-export-by-unique-id-2556151-3-D7.patch, failed testing.

mattsqd’s picture

mattsqd commented
StatusFileSize
new features-link-uuid-and-export-by-unique-id-2556151-5-D7.patch21.81 KB

Fixed missing mlid issues.

mattsqd’s picture

mattsqd commented
Status: Needs work » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work

This needs a reroll, it no longer applies cleanly after #2353585: UUID export and import of menu items linking to nodes, terms and users was committed.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Closed (duplicate)

You know, all of these changes were committed separately.