There are cases when you may be using some form of teaser display aggregated on one page (such as in a view) where you want the share links to share the URL of the entity, not the current page URL.
This feature would allow you to provide an optional context when using the content type tools plugin which will change the url and title (st_url and st_title attributes respectively) of the social links to point to the entity provided as context.

CommentFileSizeAuthor
#17 2555999-partly-reverted.patch2.65 KBberliner
#5 allow_widget_links_to-2555999-5.patch2.28 KBnitesh sethia
#3 allow_widget_links_to-2555999-3.patch2.28 KBnitesh sethia
#2 allow-widget-links-to-point-to-entity-2555999-2.patch2.61 KBeric115

Comments

Eric115 created an issue. See original summary.

eric115’s picture

eric115 commented
Status: Active » Needs review
StatusFileSize
new allow-widget-links-to-point-to-entity-2555999-2.patch2.61 KB

Patch file

nitesh sethia’s picture

nitesh sethia commented
StatusFileSize
new allow_widget_links_to-2555999-3.patch2.28 KB

Have updated the code.

Status: Needs review » Needs work

The last submitted patch, 3: allow_widget_links_to-2555999-3.patch, failed testing.

nitesh sethia’s picture

nitesh sethia commented
Status: Needs work » Needs review
StatusFileSize
new allow_widget_links_to-2555999-5.patch2.28 KB
navneet0693’s picture

navneet0693 commented
Status: Needs review » Needs work
navneet0693’s picture

navneet0693 commented
Status: Needs work » Needs review
navneet0693’s picture

navneet0693 commented

Patch looks great, taking up for reviewing it.

navneet0693’s picture

navneet0693 commented
Status: Needs review » Reviewed & tested by the community

Working fine.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Issue tags: +Needs tests

can we add tests here.

purushotam.rai’s picture

purushotam.rai commented
Status: Reviewed & tested by the community » Patch (to be ported)

purushotam.rai’s picture

purushotam.rai commented
Status: Patch (to be ported) » Fixed
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Version: 7.x-2.12 » 7.x-2.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

berliner’s picture

berliner commented

This patch wasn't ready for merging.

  1. It didn't only allow links to an optional entity context, but also effectively removed the ability to link to the current page URL from inside the panels block. This removes a complete set of use cases where you might have context objects available on the page, but don't want to use them for the creation of the shared link
  2. The fact that it defaults to use an available context object on preconfigured panels pages effectively breaks these, removing the share links that worked properly before an update to the recent version (2.13 in this case)
  3. Removes the Variable option from the select options for the Path to share without an adequate update path or information about that.
  4. When configuring the sharethis plugin on a panels page that has context objects, we now still have the availability of setting the entity argument to none, but in this case we are left with the options of linking to the front page or to an external URL, but not to the current page URL

So this committing this patch broke working functionality without need and without a highly visible notice for site owners or developers.

I would strongly vote to revert this patch and re-work on it, that's why I'm commenting here instead of opening a new issue.

berliner’s picture

berliner commented
StatusFileSize
new 2555999-partly-reverted.patch2.65 KB

I realize this release is out there for quite a while now, maybe I'm mistaken, but just in case, I'll attach a patch against the current dev containing my proposal that should keep the new functionality _and_ the old one.
I can't properly test this currently as I'm unable to make the 2.13 version of this module work correctly. This is more intended to show what I'm after here.