Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
There are cases when you may be using some form of teaser display aggregated on one page (such as in a view) where you want the share links to share the URL of the entity, not the current page URL.
This feature would allow you to provide an optional context when using the content type tools plugin which will change the url and title (st_url and st_title attributes respectively) of the social links to point to the entity provided as context.
Comment | File | Size | Author |
---|---|---|---|
#17 | 2555999-partly-reverted.patch | 2.65 KB | berliner |
#5 | allow_widget_links_to-2555999-5.patch | 2.28 KB | Nitesh Sethia |
#2 | allow-widget-links-to-point-to-entity-2555999-2.patch | 2.61 KB | Eric115 |
Comments
Comment #2
Eric115 CreditAttribution: Eric115 at PreviousNext commentedPatch file
Comment #3
Nitesh Sethia CreditAttribution: Nitesh Sethia as a volunteer and at QED42 commentedHave updated the code.
Comment #5
Nitesh Sethia CreditAttribution: Nitesh Sethia as a volunteer and at QED42 commentedComment #6
navneet0693 CreditAttribution: navneet0693 as a volunteer and at QED42 commentedComment #7
navneet0693 CreditAttribution: navneet0693 as a volunteer and at QED42 commentedComment #8
navneet0693 CreditAttribution: navneet0693 as a volunteer and at QED42 commentedPatch looks great, taking up for reviewing it.
Comment #9
navneet0693 CreditAttribution: navneet0693 as a volunteer and at QED42 commentedWorking fine.
Comment #10
naveenvalechacan we add tests here.
Comment #11
purushotam.rai CreditAttribution: purushotam.rai at QED42 commentedComment #13
purushotam.rai CreditAttribution: purushotam.rai at QED42 commentedComment #14
naveenvalechaComment #16
berliner CreditAttribution: berliner commentedThis patch wasn't ready for merging.
So this committing this patch broke working functionality without need and without a highly visible notice for site owners or developers.
I would strongly vote to revert this patch and re-work on it, that's why I'm commenting here instead of opening a new issue.
Comment #17
berliner CreditAttribution: berliner commentedI realize this release is out there for quite a while now, maybe I'm mistaken, but just in case, I'll attach a patch against the current dev containing my proposal that should keep the new functionality _and_ the old one.
I can't properly test this currently as I'm unable to make the 2.13 version of this module work correctly. This is more intended to show what I'm after here.