Closed (fixed)
Project:
Drupal 7 to Modern Drupal Module Upgrader
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
19 Aug 2015 at 22:00 UTC
Updated:
5 Sep 2015 at 08:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
dstolComment #3
dstol.
.
fix before commit
Comment #4
phenaproximaApart from these nitpicks, looks great! You, sir, are my hero.
This should be a countQuery(), and it should also check for classes which extend DrupalUnitTestCase (OR condition).
Let's delete the commented-out line and add a TODO here explaining that file name resolution is temporarily unavailable due to changes in Pharborist.
Nit: extra line of white space.
This could just be
->each([$this, 'add']), like in addFile().Can you add a TODO comment above the disabled line, explaining what breaks?
For clarity's sake, can you change the variable name from $collection to $node (since not all indexers will return a collection)?
Comment #5
dineshw commentedBingo, The patch just works fine!!!
@dstol @phenaproxima : You both saves my day :)
@dstol Thanks a ton, saved my day!
@phenaproxima : I'm just wondering should I go ahead and apply changes suggested by you in comment #4 , let me know if you want me to test it!
Comment #6
phenaproxima@dineshw: The changes in #4 are just nitpicks. @dstol's patch fixes the failures, so the stuff in #4 is just stuff I'd like him to add before I commit this patch. They're not necessary to get things done. :)
Comment #7
dineshw commentedSounds great!
Comment #8
dstolComment #10
dstolComment #11
phenaproximaThank you!
Comment #13
dineshw commentedThanks!