Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
14 Aug 2015 at 19:36 UTC
Updated:
29 Oct 2015 at 11:26 UTC
Jump to comment: Most recent
Comments
Comment #2
samirmtl commentedMay be similar to this already exist module : https://www.drupal.org/project/views_autorefresh
Comment #3
ajalan065 commentedHi ahmed rabie,
I have not gone through the functionality of the code. On reviewing the code, found quite some issues.
Much cleanliness required in your project.
1. Please remove auto_refresh_views.info from your project which seems to contain nothing.
2. No need for extra sub-directory within the project. You can keep the files directly under "auto_refresh_views" directory.
3. Remove the *.*~ duplicate files.
4. Remove the LICENSE.txt.
5. In the *.info file, only one blank line is expected at the end of the file instead of two.
Also, no need to include the lines
.
You have written core=7.x twice. Remove the second one(with the quotes). And also no need of version tag.
6. Wrong use of comments in the *.install file.
should be preceded by the comment
. Similar changes for the function refresh_views_schema().
Now coming to the coding part,
7. In the *.install file -->function refresh_views_schema() {..}
should be
8. In the *.module file, wrong code of hook_help(). Please refer to this hook_help()
9. Also make similar changes in the *.module file as given in my point 7.
10. README not appropriate. Please refer to guidelines for in-project documentation and/or README template.
11. A lot of extra spaces and lines at inappropriate places. Please perform Pareview to have a neat and clean code.
Participate in the Review Bonus Program to gain higher priority.
Set back the status to "Needs Review", once all the mentioned issues are resolved.
@SamirMtl, Good observations. But module duplicacy does not require the status to set back to "Needs Work".
Comment #4
ajalan065 commentedComment #5
ahmed rabie commentedhi SamirMtl,
thanks you for repaly may be is similar but my module is simply to use just install module and creat your own view and my moduel will run auto without any configuration.
Comment #6
ahmed rabie commentedhi ajalan065,
thank you for your feedback and i will check your comments and back to you .
Comment #7
ahmed rabie commentedhi ajalan065,
can you check please after modifications .
Comment #8
ahmed rabie commentedComment #9
ajalan065 commentedHi ahmed rabie,
Looks good to me except for two points.
1. In the *.install file, the comment should be hook_schema() rather than hook_install().
2. You have not made the changes as per points 7 and 9 of my previous review. https://www.drupal.org/node/2551669#comment-10224027
Comment #10
ahmed rabie commentedthank you ajalan065 can you check again please .
Comment #11
ahmed rabie commentedComment #12
th_tushar commentedHi ahmed rabie,
The module Views Auto-Refresh already exists for this functionality.
Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the views_autorefresh issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.
If that fails for whatever reason please get back to us and set this back to "needs review".
Comment #13
ahmed rabie commentedDear th_tushar ,
my moudel is easy to use just install moudel and any views will be contant update auto .
Comment #14
ahmed rabie commentedComment #15
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxahmed_rabie2551627git
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #16
ahmed rabie commentedthank you PA Robot i will check it and back to you to review again .
Comment #17
PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.