This is module that allows to set timer to Refresh in the views and auto update content.

Project page: https://www.drupal.org/sandbox/ahmed_rabie/2551627

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/ahmed_rabie/2551627.git auto_refresh_views
Drupal version: 7, not further dependancies

Comments

ahmed rabie created an issue. See original summary.

samirmtl’s picture

Status: Needs review » Needs work

May be similar to this already exist module : https://www.drupal.org/project/views_autorefresh

ajalan065’s picture

Hi ahmed rabie,
I have not gone through the functionality of the code. On reviewing the code, found quite some issues.
Much cleanliness required in your project.
1. Please remove auto_refresh_views.info from your project which seems to contain nothing.
2. No need for extra sub-directory within the project. You can keep the files directly under "auto_refresh_views" directory.
3. Remove the *.*~ duplicate files.
4. Remove the LICENSE.txt.
5. In the *.info file, only one blank line is expected at the end of the file instead of two.
Also, no need to include the lines

files[] = refresh_views.module
files[] = refresh_views.install

.
You have written core=7.x twice. Remove the second one(with the quotes). And also no need of version tag.
6. Wrong use of comments in the *.install file.

function refresh_views_uninstall() {
  drupal_uninstall_schema('refresh_views');
} 

should be preceded by the comment

/**
 * Implements hook_uninstall().
 */

. Similar changes for the function refresh_views_schema().

Now coming to the coding part,
7. In the *.install file -->function refresh_views_schema() {..}
should be

function refresh_views_schema() {
  $schema = array();
  $t=get_t();
  $schema['view_timer'] = array(
    'description' =>$t('Stores information about user logins'),
    'fields' => array(
      'timer' => array(
        'description' => $t('The User ID of the person who logged in'),
        'type' => 'int',
        .....
}

8. In the *.module file, wrong code of hook_help(). Please refer to this hook_help()
9. Also make similar changes in the *.module file as given in my point 7.
10. README not appropriate. Please refer to guidelines for in-project documentation and/or README template.
11. A lot of extra spaces and lines at inappropriate places. Please perform Pareview to have a neat and clean code.

Participate in the Review Bonus Program to gain higher priority.
Set back the status to "Needs Review", once all the mentioned issues are resolved.

@SamirMtl, Good observations. But module duplicacy does not require the status to set back to "Needs Work".

ajalan065’s picture

Title: Auto Refresh Views » [D7]Auto Refresh Views
ahmed rabie’s picture

hi SamirMtl,
thanks you for repaly may be is similar but my module is simply to use just install module and creat your own view and my moduel will run auto without any configuration.

ahmed rabie’s picture

hi ajalan065,
thank you for your feedback and i will check your comments and back to you .

ahmed rabie’s picture

hi ajalan065,
can you check please after modifications .

ahmed rabie’s picture

Status: Needs work » Needs review
ajalan065’s picture

Hi ahmed rabie,
Looks good to me except for two points.
1. In the *.install file, the comment should be hook_schema() rather than hook_install().
2. You have not made the changes as per points 7 and 9 of my previous review. https://www.drupal.org/node/2551669#comment-10224027

ahmed rabie’s picture

thank you ajalan065 can you check again please .

ahmed rabie’s picture

Priority: Normal » Major
th_tushar’s picture

Status: Needs review » Closed (duplicate)

Hi ahmed rabie,
The module Views Auto-Refresh already exists for this functionality.

Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the views_autorefresh issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

ahmed rabie’s picture

Dear th_tushar ,
my moudel is easy to use just install moudel and any views will be contant update auto .

ahmed rabie’s picture

Status: Closed (duplicate) » Needs review
PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxahmed_rabie2551627git

I'm a robot and this is an automated message from Project Applications Scraper.

ahmed rabie’s picture

thank you PA Robot i will check it and back to you to review again .

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.