Label hides when picking a different language for a job

Here is the test only patch.

contains test with fix. (contains minor change in test case). I will upload the new test only patch.

Here is test only patch and now should fail properly :)

Now as #9 is failing properly, here is patch with fix and test case.

This interdiff is from #8.

This test is wrong, you don't change the language, to assert that you should use ajax to change to french.

And when you modify somthing, please, ulpoad the test_only, the patch and the interdiff in this order and in the same comment. Thanks.

@edurenye : thanks for your feedback but I think, ajax trigger on language is already there in 'testCheckoutForm'

$job = tmgmt_job_create('en', 'de', 0);
    $job->save();
    $edit = array(
      'target_language' => 'de',
    );
    $this->drupalPostAjaxForm('admin/tmgmt/jobs/' . $job->id(), $edit, 'target_language');
    $this->assertFieldByXPath('//select[@id="edit-translator"]/option[1]', 'Test translator (auto created)');

What I have just check is that label field is available after ajax or not.

Yes, but is checking "de" language that is the first in the list, so the form is the default one, so this method is not called, maybe we should change to the second that is greek.
Maybe somthing like this:

$edit = array(
      'target_language' => 'el',
      'settings[action]' => 'translate',
    );
    $this->drupalPostAjaxForm('admin/tmgmt/jobs/' . $job->id(), $edit, 'target_language');
    $this->assertFieldByXPath('//label[@for="edit-label-0-value"]', 'Label');

I'm not really sure that the method is not called, but if you try it manually, the id change when the method is called, so I deducted this.

Maybe other solution could be just deleting those lines, I don't understand why we replace the label when changing the language, if we delete that, the default label is set properly in the job. So I don't know why we need that.

I don't know why the test only case is passing and test+fix is failing ahhhhhh....

Don't desperate :)
There were something commited between both, just rebase and upload.
I think maybe we don't need 'settings[action]' => 'translate', I just adapted another assertion there. What I don't understand is why the test_only is not failing, seems like the problem is just present when you check it manually, and I don't get to know why.

+++ b/src/Form/JobForm.php
@@ -543,8 +543,8 @@ class JobForm extends TmgmtFormBase {
     // Replace value of the label field with ajax on language change.
     // @todo This manual overwrite is necessary because somehow an old job entity seems to be used.
-    $form['info']['label']['#value'] = $form_state->getValue('label');
-    $response->addCommand(new ReplaceCommand('#tmgmt-ui-label', $this->renderer->render($form['info']['label'])));
+    $form['label']['widget'][0]['value']['#value'] = $form_state->getValue('label')[0]['value'];
+    $response->addCommand(new ReplaceCommand('#tmgmt-ui-label', $this->renderer->render($form['label']['widget'][0]['value'])));

And I think the solution may be just delete this. Because is old code that is not so understandable, so check what whappens if we delete that. If somthing breaks, then will help us to understand what is doing this.

@joshi.rohit100 are you still working in this issue?

@edurenye: Sorry for delaying. Yes I am still on it.

And as per #25, lets see what happens.

I am still facing same problem as test-only patch is not failing. Don't know why. Cache ?

It didn't work locally but I am uploading it here for feedback.

Thanks for your answer.
Seems to work without those lines, so now we need the difficult part, so make a test that fails with the lines and works without the lines.
I tried to dissable the cache and the test is still don't working properly.
@juanse254 found the problem, it just happens if tmgmt_file is enabled, but then all the test breaks...

+++ b/src/Tests/TMGMTUiTest.php
@@ -249,6 +249,13 @@ class TMGMTUiTest extends TMGMTTestBase {
+    // Check for label field.
...
+      'target_language' => 'el',
...
+		$this->drupalPostAjaxForm('admin/tmgmt/jobs/' . $job->id(), $edit, 'target_language');
+		$this->assertField('label[0][value]', 'Label');

Please set up your IDE to use two spaces as a tab (as listed in the coding guidelines).

Ok, @Berdir says that this can just be tested manually, so I tested it manually and works fine.
The good patch is the 27: https://www.drupal.org/node/2550597#comment-10232361

That is correct, but the feedback from @LKS90 hasn't been addressed.

Diff is from #30

OK!

So in this, I have removed test case.

Ok, it's the same as 27, so is the one that works.
Good job!

Confirmed manually, nice find.