Deprecate unused functions _tracker_myrecent_access and _tracker_user_access

Moving to 8.4.x because removing functions might be disruptive.

Patch no longer applies.

I see that migrate_drupal/tests/fixtures/drupal7.php has a reference to these functions, but that could be a reference to the D7 implementations. I'm not familiar enough with migrations to know for sure.

Re-rolled.

Looks good. Thanks.

Woah, nice catch!

Likewise with #2551259-11: Deprecate dead code locale_translation_manual_status(), we'll want to deprecate here rather than full-out remove.

Deprecation how-to: https://www.drupal.org/core/deprecation

As per #15 added the @deprecated . please validate.

Testbot infrastructure failure:

00:00:02.107 Performing git checkout of git://git.drupal.org/project/drupal.git -b 8.4.x to /var/lib/drupalci/workspace/jenkins-drupal_patches-17660/source.
00:00:02.107 Git Command: git clone -b 8.4.x --depth 1 git://git.drupal.org/project/drupal.git '/var/lib/drupalci/workspace/jenkins-drupal_patches-17660/source'
00:00:02.108 Checkout Error
00:00:02.108 git clone -b 8.4.x --depth 1 git://git.drupal.org/project/drupal.git '/var/lib/drupalci/workspace/jenkins-drupal_patches-17660/source' 2>&1
00:00:02.109 Return Code:128
00:00:02.109 Cloning into '/var/lib/drupalci/workspace/jenkins-drupal_patches-17660/source'...
00:00:02.109 error: copy-fd: write returned No space left on device
00:00:02.110 fatal: cannot copy '/usr/share/git-core/templates/description' to '/var/lib/drupalci/workspace/jenkins-drupal_patches-17660/source/.git/description': No space left on device
00:00:02.111 PHP Warning:  file_put_contents(): Only 0 of 548 bytes written, possibly out of free disk space in /opt/drupalci/testrunner/src/DrupalCI/Build/Build.php on line 481

So the difference between this and #2551259: Deprecate dead code locale_translation_manual_status() is that in the fine print of https://www.drupal.org/core/d8-bc-policy#underscore, underscore-prefixed functions etc. are explicitly internal. However, @catch and I discussed this and agreed that it's still probably best to deprecate things by default as a best practice, which is what the latest patch does, so +1.

Let's also explicitly add an @internal to these along with the deprecation. Then we can tack a message to the end of the standard deprecation message like:
As internal API, this may also be removed in a minor release if it becomes needed.

Forgot to mention, we'll also update the deprecation documentation to cover this, so that we can deprecate internal API first since it's just less work, but still make it clear that it's internal API and so if there is a problem with it, we're not going to do refactoring to protect it.

Marking CNW for the additional @internal documentation.

Sorry, forgot to mark it NW.

As per #23. Added @internal documentation. please validate.

Updated the policy: https://www.drupal.org/core/deprecation#internal

Thanks @harsha012 -- looks pretty good. I would move the sentence from the @internal to the end of the @deprecated. The example at the link above (which we just wrote now) should help. :)

Also, be sure your comments wrap at 80 characters to follow our coding standards.

Thanks for helping with this!

As per #27 made some improvement. please validate the patch

Thanks @harsha012. Just a few more small issues.

+++ b/core/modules/tracker/tracker.module
@@ -152,6 +159,12 @@ function _tracker_myrecent_access(AccountInterface $account) {
+ * @deprecated _tracker_user_access() is depriciated in Drupal 8.4.0 and will be
+ * removed before Drupal 9.0.0.See https://www.drupal.org/node/2550581. As
+ * internal API, _tracker_user_access() may also be removed in a minor release.

1. "deprecated" is misspelled. But actually the first part,
   

   _tracker_myrecent_access() is depriciated <code>,
    can be dropped in the code comment. It just needs to be in the <code>@trigger_error()

   . See https://www.drupal.org/core/deprecation for examples.

2. I also don't see a @trigger_error? Is it excluded on purpose? See: https://www.drupal.org/core/deprecation
3. There's a missing space after the period after "Drupal 9.0.0."
4. Every line of the comment after the first should be indented by two spaces; see core/modules/system/src/Tests/Cache/GenericCacheBackendUnitTestBase.php for an example. (I just picked that at random out of a grep.)

Please take a close look at the examples in https://www.drupal.org/core/deprecation and try to update the patch based on that. Thanks!

@xjm, please validate the patch now.

Thanks @harsha012, that looks much closer.

1. It looks like the messages are referencing this issue, rather than a change record. We would create a change record and reference that... except since we agreed it's internal API I don't think that's the right course of action. So in this case, how about we remove the sentence See https://www.drupal.org/node/2550581 from the messages?

2. +++ b/core/modules/tracker/tracker.module
   @@ -135,6 +135,12 @@ function tracker_cron() {
   + *   _tracker_user_access()may also be removed in a minor release.
   

   Missing space between _tracker_user_access() and may.

3. +++ b/core/modules/tracker/tracker.module
   @@ -145,6 +151,9 @@ function tracker_cron() {
   +  @trigger_error('_tracker_myrecent_access() is deprecated in Drupal 8.4.0 and
   +   will be removed before Drupal 9.0.0. See https://www.drupal.org/node/2550581.
   +   ', E_USER_DEPRECATED);
   
   @@ -162,6 +177,9 @@ function _tracker_myrecent_access(AccountInterface $account) {
   +  @trigger_error('_tracker_user_access is deprecated in Drupal 8.4.0 and
   +   will be removed before Drupal 9.0.0. See https://www.drupal.org/node/2550581.
   +   ', E_USER_DEPRECATED);
   

   Ah, functional code does not need to be wrapped to 80 characters -- just the documentation. You can put function calls on multiple lines to improve readability, but we would do that by putting each parameter on one line -- but in this case, I think it's fine to just put this all on one line.

4. +++ b/core/modules/tracker/tracker.module
   @@ -152,6 +161,12 @@ function _tracker_myrecent_access(AccountInterface $account) {
   + *   https://www.drupal.org/node/2550581. As internal API, _tracker_user_access()
   

   This line is just one character too long. :) Looks like you noticed that for the other copy of the docblock and rewrapped it (thence the missing space) but it didn't make it to this one.

5. +++ b/core/modules/tracker/tracker.pages.inc
   @@ -19,8 +19,6 @@
   - *
   - * @see tracker_menu()
   

   We do still need to remove the other two references to this. (Either that, or remove this hunk from the patch, but it makes sense as part of this issue's scope since the functions we're deprecating were the helpers for it.) So there should be three lines like this in the patch for each of these references:

   [ibnsina:drupal | Tue 14:00:06] $ grep -r "tracker_menu" *
   core/modules/tracker/tracker.module: * @see tracker_menu()
   core/modules/tracker/tracker.module: * @see tracker_menu()
   core/modules/tracker/tracker.pages.inc: * @see tracker_menu()

(Sorry, I keep failing to actually mark the issue NW.) :)

I updated https://www.drupal.org/node/2856615/revisions/view/10512193/10514226 to clarify that internal API changes might not have change records, including changing the example. Sorry for the confusion over that; this issue is helping us finalize the policy for these sorts of changes. :)

@xjm, I hope now the issue will be fixed with this patch. please validate

Getting closer... Still doesn't address #35.1, though:

+++ b/core/modules/tracker/tracker.module
@@ -135,16 +135,20 @@ function tracker_cron() {
+  @trigger_error('_tracker_myrecent_access() is deprecated in Drupal 8.4.0 and will be removed before Drupal 9.0.0. See https://www.drupal.org/node/2550581.', E_USER_DEPRECATED);

@@ -152,16 +156,20 @@ function _tracker_myrecent_access(AccountInterface $account) {
+  @trigger_error('_tracker_user_access() is deprecated in Drupal 8.4.0 and will be removed before Drupal 9.0.0. See https://www.drupal.org/node/2550581.', E_USER_DEPRECATED);

Thanks @Mile23.

+++ b/core/modules/tracker/tracker.module
@@ -135,16 +135,20 @@ function tracker_cron() {
+ *   internal API, _tracker_user_access() may also be removed in a minor release.

@@ -152,16 +156,20 @@ function _tracker_myrecent_access(AccountInterface $account) {
+ *   internal API, _tracker_user_access() may also be removed in a minor release.

These lines are also one character too long again. Please configure your editor or IDE to show you where 80 characters is so that you can wrap comments correctly. You can also still use Dreditor for now to see your patch on Drupal.org and review it. The documentation standards for this are here: https://www.drupal.org/node/1354#drupal

@Mile23 and @xjm,

please check the below link for change recored. please validate it

https://www.drupal.org/node/2885190

Also made changes as per the comment #40.

Unpublished the change record since this hasn't been committed yet.

We still need to remove the links to this issue as per #39 and #35.1.

Fixed 39 and 35.1.

Thanks! LGTM.

Committed 950362e and pushed to 8.4.x. Thanks!

Publish the cr