While porting a module to D8 and getting familiar with the handful of changes between D7 and D8, I saw a reference in node_page_title that said @see node_menu(). After a bit of digging, I confirmed that node_menu() no longer exists.
I initially was going to remove just the @see to remove a little confusion, but then did a little more digging and it seems node_page_title isn't used either. It's unclear to me if the function needs to be defined for the two migrate_drupal/src/Tests referencing it for D6 and D7:
https://api.drupal.org/api/drupal/core!modules!node!node.module/function...
| Issue category | Bug|Task cleanup of existing code |
|---|---|
| Issue priority | Minor|Normal because the impact is honestly not that much, but its one small thing less to care about. |
| Disruption | No disruption, as if anyone was still using it, they are doing it wrong anyway. This function was de facto deprecated already. |
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | drupal-remove-node_page_title-2546662.patch | 662 bytes | jeremy |
Comments
Comment #2
jeremy commentedAttached patch removes the entire function; if it's actually needed, then perhaps we could just remove the erroneous @see node_menu() which is confusing to people reading the code.
Comment #3
dawehnerYeah less code!
I think the two places in migrate are just part of a DB dump of the menu_router table. Given that the string menu_router is not used anywhere anymore,
it is doubtful that these dumps itself are really useful.
Comment #4
alexpottYes this is dead code that can be removed under the beta evaluation policy but I think we need a CR so any contrib will know and know what to do instead.
Comment #5
jeremy commentedHere's a CR:
https://www.drupal.org/node/2549923
Comment #6
borisson_Change record looks sufficient, removed the tag and set back to RTBC.
Comment #8
alexpottCommitted 09a0c9f and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation and the issue summary.