Discovered during #2505499: Explicitly support render arrays in hook_requirements(). hook_requirements() is supposed to cause installation to fail if requirements are not met, but it does not do so reliably. Implementing a failing requirement for Taxonomy or Node prevents the installation of Standard, but implementing it for Text or for Standard itself does not. In the latter two cases, Drupal is still installed, and the hook_requirements() failure is still displayed at runtime if it is returned regardless of $phase.
Demonstrations attached.
?
| Comment | File | Size | Author |
|---|---|---|---|
| hook-requirements-text-FAIl-FAILS.patch | 463 bytes | xjm | |
| hook-requirements-taxonomy-FAIL.patch | 494 bytes | xjm |
Comments
Comment #2
xjmI don't think #1933962: Dependent modules are still installed when requested modules return errors in hook_requirements('install') is the same issue (and not 100% sure it still exists) but worth testing manually.
Comment #13
quietone commentedI tested this on Drupal 9.3.x and was able to reproduce the problem. I applied the patch which forces a requirements failure in text_requirements and did installed standard via drush. I also had a breakpoint set in text_requirements and that code was never called. So, it seems that one problem is that the requirements for dependent modules are not being checked.
The install completed and going to the site, there was no error message and nothing in the log. That part is different that the IS.