Problem/Motivation

Configurable fields on relationships are not visible in views ui.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 needs_tests_update-2548701-11.patch1.1 KBtbonomelli
#8 2548701-8.diff673 byteshypertext200
#2 2548701-1.patch4.29 KBwebflo

Comments

webflo created an issue. See original summary.

webflo’s picture

webflo commented
StatusFileSize
new 2548701-1.patch4.29 KB
luksak’s picture

luksak
he/him
commented

Works for me so far.

jeroen.b queued 2: 2548701-1.patch for re-testing.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Title: Update views integration » Needs tests: Update views integration
Status: Needs review » Needs work
Issue tags: +Needs tests

OK committing this.
Still, i'm concerned about almost no test coverage in this module and basically many things are only tested by the module Paragraphs that uses it...

I think we should have some basic test view to proof things work.

jeroen.b’s picture

jeroen.b commented
Issue tags: +needs fix before Drupal 8 release
hypertext200’s picture

hypertext200
he/him
Primary language Singhalese
Location New York City
commented
Status: Needs work » Needs review
StatusFileSize
new 2548701-8.diff673 bytes

I have Paragraphs module installed with this module and I can't get any Paragraphs loaded by the node id, so I had to do this change in order to make it work. See the patch file. It was referencing the wrong field.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Needs work

Would be great if you could help us cover your case in a test.

tbonomelli’s picture

tbonomelli commented
Assigned: Unassigned » tbonomelli
tbonomelli’s picture

tbonomelli commented
Status: Needs work » Needs review
StatusFileSize
new needs_tests_update-2548701-11.patch1.1 KB

Added the test module and its definition.

Need to create a view and export its config to see if the fields that we added are shown.
I'm not sure which settings I need to use for the view.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Needs work

We don't need to implement the hook_views_data_alter to import a view in the test module.

This issue is starting to mix things.
1) We want to have test coverage for the thing we implemented.
2) There might be additional use cases like Paragraphs that need more test coverage and fix / improvements. Should be separate follow-up issues.

tbonomelli’s picture

tbonomelli commented
Assigned: tbonomelli » Unassigned
idebr’s picture

idebr commented
Title: Needs tests: Update views integration » Update views integration
Status: Needs work » Fixed
Issue tags: -Needs tests, -needs fix before Drupal 8 release
Related issues: +#2799479: Views doesn't recognize relationship to host

Considering the (partial) commit, I suggest we implement the tests in #2799479: Views doesn't recognize relationship to host. The related issue includes improvements to Views integration that should make the use case for Entity reference revisions in Views easier to demonstrate.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.