Problem/Motivation

table ul.link styles are not needed in Bartik, the code is not used anywhere.

Reasons for removing this code by @emma.maria.

  1. I have checked when these styles were added to Bartik and they have existed since the first commit. So there's no solid evidence that they are required for a recent specific use case.
  2. I have checked the Seven theme for the exact same selector to see if that theme has a use case in the admin styles and it is not.
  3. Bartik does not have this markup anywhere on the frontend.
  4. The admin theme now uses dropbuttons in tables and not lists.
  5. You cannot create the table ul.link natively in a WYSIWYG field.

Proposed resolution

Remove table ul.link CSS from Bartik.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

none

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because this is redundant code cleanup.
Issue priority Not critical because Bartik functions fine.
Unfrozen changes Unfrozen because it only changes CSS.
Prioritized changes The main goal of this issue is CSS clean up task.
Disruption Non-disruptive.
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

leolandotan’s picture

Hi,
I followed the recommended changes and created a patch. Did the following:

  1. Created a custom page with a table and a list inside.
  2. Applied the CSS changes to core/themes/bartik/css/components/table.css
  3. Applied the patch into the main branch using `git checkout 8.0.x` then `git apply -v core-follow_up_bartik_table_clean_up-2543928-0.patch`.

This is also a sample screenshot:
Leo Page Example D8

By the way, I'm not so sure about the relation of https://www.drupal.org/node/254257. It's brings me to the release page of the Taxonomy Browser module 6.x-1.1.

leolandotan’s picture

Assigned: Unassigned » leolandotan

Sorry forgot to assign to myself as stated in Novice contributing 1: Get an issue.

emma.maria’s picture

Title: Clean up the "Table" component in Bartik - "table ul.links"-styles » Refactor link styles within tables in Bartik.
emma.maria’s picture

Issue summary: View changes
Issue tags: +Needs manual testing
FileSize
38.44 KB

I cannot recreate the content (without manually editing the source markup) used for the original problem in the issue summary. I therefore cannot recreate the bug being pointed out.

How do you add a list that has the markup ul.list in a table within the WYWISYG out of the box?

Using what is given in the Full HTML settings of the WYSIWYG, I produced the following markup for lists with links...

<td>
  <ul>
    <li>
      <a href="google.com">I am list item that is a link</a>
   </li>
  </ul>
</td>

and the frontend does not look visually broken?

Bartik should work 'out of the box' and the default solution works fine. I feel like there might be some legacy Table CSS styles leftover here.

Can someone manually test this and confirm if I have missed something here?

kattekrab’s picture

I'm not sure I understand the problem in the Issue Summary.

The "table ul.links"-styles don´t work well in my opinion.

Does this refer to the bullet point alignment in the screenshot?

I created a table using the wysiwyg editor, and manually edited source to add the nested list. Screen shot and html markup below.

screenshot

<table border="1" cellpadding="1" cellspacing="1" style="width: 500px;">
	<thead>
		<tr>
			<th scope="row">Test Content</th>
			<th scope="col">Test Content</th>
		</tr>
	</thead>
	<tbody>
		<tr>
			<th scope="row">Test Content</th>
			<td>
			<ul>
				<li>This is a list item</li>
				<li>This is a list item
				<ul>
					<li><a href="http://drupal.org">This is a nested list item</a></li>
					<li><a href="http://drupal.org">This is a nested list item</a></li>
				</ul>
				</li>
				<li>This is a list item</li>
			</ul>
			</td>
		</tr>
		<tr>
			<th scope="row">Test Content</th>
			<td>&nbsp;</td>
		</tr>
	</tbody>
</table>
emma.maria’s picture

I did not know how to replicate the problem in the issue summary without editing the source. You can create a list or even a nested list with links without the markup shown in the issue summary.

I just need to see that the markup used in the issue summary is not available out of the box. At this point in the cycle I am hesitant to start adding fixes for something most users of Bartik will not even come across :)

emma.maria’s picture

Title: Refactor link styles within tables in Bartik. » Remove table ul.link styles in Bartik.
Assigned: leolandotan » Unassigned
Category: Bug report » Task
Issue summary: View changes
Status: Needs review » Active
Issue tags: -Needs manual testing

I have come to the conclusion that the table ul.link styles are not needed in Bartik.

Reasons for this:

  1. I have further checked when these styles were added to Bartik and they have existed since the first commit. So there's no solid evidence that they are required for a recent specific use case.
  2. I have checked the Seven theme for the exact same selector to see if that theme has a use case in the admin styles and it is not.
  3. Bartik does not have this markup anywhere on the frontend.
  4. The admin theme now uses dropbuttons in tables and not lists.
  5. You cannot create the table ul.link natively in a WYSIWYG field.

Therefore I am changing the scope of this issue.

leolandotan’s picture

Status: Active » Needs review
FileSize
493 bytes

I have updated the patch based on the new requirements with regards to the following reasons stated by @emma.maria in comment #17.

emma.maria’s picture

Status: Needs review » Reviewed & tested by the community

Thanks @leolando.tan for the patch in #8.

I can confirm the table ul.links styles have been removed from the CSS and that this does not visual effect anything on the frontend or in the admin theme.

Setting this to RTBC.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Yay, less code. :)

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 8115352 on 8.0.x
    Issue #2543928 by leolando.tan, emma.maria, kattekrab, mori: Remove...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.