Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
table ul.link
styles are not needed in Bartik, the code is not used anywhere.
Reasons for removing this code by @emma.maria.
- I have checked when these styles were added to Bartik and they have existed since the first commit. So there's no solid evidence that they are required for a recent specific use case.
- I have checked the Seven theme for the exact same selector to see if that theme has a use case in the admin styles and it is not.
- Bartik does not have this markup anywhere on the frontend.
- The admin theme now uses dropbuttons in tables and not lists.
- You cannot create the table ul.link natively in a WYSIWYG field.
Proposed resolution
Remove table ul.link
CSS from Bartik.
Remaining tasks
User interface changes
None
API changes
None
Data model changes
none
Beta phase evaluation
Issue category | Task because this is redundant code cleanup. |
---|---|
Issue priority | Not critical because Bartik functions fine. |
Unfrozen changes | Unfrozen because it only changes CSS. |
Prioritized changes | The main goal of this issue is CSS clean up task. |
Disruption | Non-disruptive. |
Comment | File | Size | Author |
---|---|---|---|
#8 | core-remove_bartik_table_ul_link_styles-2543928-7.patch | 493 bytes | leolandotan |
#5 | Screen Shot 2015-08-28 at 20.18.14.png | 41.8 KB | kattekrab |
#4 | Screen Shot 2015-08-28 at 11.45.17.png | 38.44 KB | emma.maria |
#1 | leo-page-example-d8.png | 19.11 KB | leolandotan |
#1 | core-follow_up_bartik_table_clean_up-2543928-0.patch | 715 bytes | leolandotan |
Comments
Comment #1
leolandotan CreditAttribution: leolandotan as a volunteer commentedHi,
I followed the recommended changes and created a patch. Did the following:
This is also a sample screenshot:
By the way, I'm not so sure about the relation of https://www.drupal.org/node/254257. It's brings me to the release page of the Taxonomy Browser module 6.x-1.1.
Comment #2
leolandotan CreditAttribution: leolandotan as a volunteer commentedSorry forgot to assign to myself as stated in Novice contributing 1: Get an issue.
Comment #3
emma.mariaComment #4
emma.mariaI cannot recreate the content (without manually editing the source markup) used for the original problem in the issue summary. I therefore cannot recreate the bug being pointed out.
How do you add a list that has the markup ul.list in a table within the WYWISYG out of the box?
Using what is given in the Full HTML settings of the WYSIWYG, I produced the following markup for lists with links...
and the frontend does not look visually broken?
Bartik should work 'out of the box' and the default solution works fine. I feel like there might be some legacy Table CSS styles leftover here.
Can someone manually test this and confirm if I have missed something here?
Comment #5
kattekrab CreditAttribution: kattekrab as a volunteer commentedI'm not sure I understand the problem in the Issue Summary.
Does this refer to the bullet point alignment in the screenshot?
I created a table using the wysiwyg editor, and manually edited source to add the nested list. Screen shot and html markup below.
Comment #6
emma.mariaI did not know how to replicate the problem in the issue summary without editing the source. You can create a list or even a nested list with links without the markup shown in the issue summary.
I just need to see that the markup used in the issue summary is not available out of the box. At this point in the cycle I am hesitant to start adding fixes for something most users of Bartik will not even come across :)
Comment #7
emma.mariaI have come to the conclusion that the
table ul.link
styles are not needed in Bartik.Reasons for this:
Therefore I am changing the scope of this issue.
Comment #8
leolandotan CreditAttribution: leolandotan as a volunteer commentedI have updated the patch based on the new requirements with regards to the following reasons stated by @emma.maria in comment #17.
Comment #9
emma.mariaThanks @leolando.tan for the patch in #8.
I can confirm the table ul.links styles have been removed from the CSS and that this does not visual effect anything on the frontend or in the admin theme.
Setting this to RTBC.
Comment #10
webchickYay, less code. :)
Committed and pushed to 8.0.x. Thanks!