Problem/Motivation

Steps to reproduce:
1) open admin/structure/views/view/user_admin_people
2) scroll down to "Preview" area
3) hover over title and content - no contextual menu appears, but checking markup there's a links

Proposed resolution

Make sure contextual links works in view preview

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 eb3fd5a9ef0f38ca590011603fdd968e[1].png118.17 KBfinnsky
#6 2539664-10187284.patch1.66 KBfinnsky
#1 2539664.patch2.78 KBfinnsky

Comments

finnsky’s picture

finnsky commented
StatusFileSize
new 2539664.patch2.78 KB

Hello world! Looks like HTML was wrong, I compared it with frontpage view with contextual links. Now it's has same HTML. Also should be added 'data-contextual-id' attribute.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
andypost’s picture

andypost
he/him
Primary language Russian
commented 
+++ b/core/modules/views_ui/templates/views-ui-container.html.twig
@@ -4,7 +4,6 @@
- * - attributes: HTML attributes to apply to the container element.

@@ -12,4 +11,4 @@
-<div{{ attributes }}>{{ children }}</div>
+<div class="contextual-region">{{ children }}</div>

+++ b/core/modules/views_ui/templates/views-ui-view-preview-section.html.twig
@@ -7,6 +7,7 @@
+ * - attributes: HTML attributes to apply to the container element.

@@ -15,6 +16,6 @@
-  <div class="contextual">{{ links }}</div>
+  <div {{ attributes }}>{{ links }}</div>

+++ b/core/modules/views_ui/views_ui.module
@@ -137,7 +137,6 @@ function views_ui_preprocess_views_view(&$variables) {
-          '#attributes' => array('class' => array('contextual-region')),

wtf with attributes?
they should be added dynamically if contextual module enabled

Status: Needs review » Needs work

The last submitted patch, 1: 2539664.patch, failed testing.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented 
  1. +++ b/core/modules/views_ui/templates/views-ui-container.html.twig
@@ -12,4 +11,4 @@
+<div class="contextual-region">{{ children }}</div>

    Attributes variable should be still printed. You can use attributes.addClass() to add classes. 

  2. +++ b/core/modules/views_ui/templates/views-ui-view-preview-section.html.twig
@@ -15,6 +16,6 @@
+  <div {{ attributes }}>{{ links }}</div>

    When attributes variable is being used, no additional space is needed before it

finnsky’s picture

finnsky commented
StatusFileSize
new 2539664-10187284.patch1.66 KB

hello all! Template fixes added. Buttons appear. We still need to set correct data-contextual-id attribute here: core\modules\views_ui\views_ui.theme.inc:513.

finnsky’s picture

finnsky commented
StatusFileSize
new eb3fd5a9ef0f38ca590011603fdd968e[1].png118.17 KB

Also I found that in default template parent .contextual-region class not added. This should be reason of JS error
Uncaught TypeError: Cannot read property 'top' of undefined contextual.js?v=8.0.0-dev:116

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Issue tags: -JavaScript +JavaScript

Cleaning up old bugs.

This is still broken. Not sure why you would want to use the contextual links in the preview, but yeah, the markup is there, but they don't show.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.