Problem/Motivation

This is essentially a backport from D8 core issue. The user login form lacks attributes "autocapitalize", "spellcheck" and "autocorrect" creating problems on some mobile browsers (like Safari). Previous issue seems that there is a tension between W3C compliance and usability ().

Proposed resolution

Proposed solution to add to user form:

  • autocorrect="none"
  • autocapitalize="none"
  • spellcheck="false"

Remaining tasks

- discuss
- patch
- review

User interface changes

None

API changes

None

CommentFileSizeAuthor
#18 2537190-17.patch938 bytesrobertwb
#18 2537190-17.patch938 bytesrobertwb
#11 2537814-1.patch652 bytesrobertwb
#9 2537190-9.patch902 bytesrobertwb
#6 2537190-6.patch524 bytesrobertwb
#3 2537190-3.patch525 bytesrobertwb
#2 2537190-2.patch560 bytesrobertwb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

robertwb’s picture

robertwb CreditAttribution: robertwb commented
Issue summary: View changes
robertwb’s picture

robertwb CreditAttribution: robertwb commented
FileSize
2537190-2.patch560 bytes

Attached patch implementing proposed solution.

robertwb’s picture

robertwb CreditAttribution: robertwb commented
FileSize
2537190-3.patch525 bytes

Updated - removed autofocus

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Active » Needs review
cilefen’s picture

cilefen CreditAttribution: cilefen commented 
+++ b/modules/user/user.module
@@ -1340,6 +1340,11 @@ function user_login_block($form) {
+      'autocapitalize' => 'none', ¶

You have a space at the end of this line.

robertwb’s picture

robertwb CreditAttribution: robertwb commented
FileSize
2537190-6.patch524 bytes

Removed extraneous space from line. Thanks @cilefen

cilefen’s picture

cilefen CreditAttribution: cilefen commented

Is this needed on the registration form too?

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Needs review » Needs work

It is surely needed on the /user form also, and we have to decide about the registration form.

robertwb’s picture

robertwb CreditAttribution: robertwb commented
FileSize
2537190-9.patch902 bytes

OK - attached patch has it on the /user form. The reg form is above my pay grade :) I would opt to do what they did in the d8? Which I think was not to touch it, but the form structure is much different there so that may be a bad assumption on my part.

robertwb’s picture

robertwb CreditAttribution: robertwb commented
Status: Needs work » Needs review
robertwb’s picture

robertwb CreditAttribution: robertwb commented
FileSize
2537814-1.patch652 bytes
robertwb’s picture

robertwb CreditAttribution: robertwb commented

Status: Needs review » Needs work

The last submitted patch, 11: 2537814-1.patch, failed testing.

robertwb queued 9: 2537190-9.patch for re-testing.

robertwb’s picture

robertwb CreditAttribution: robertwb commented
Status: Needs work » Needs review
robertwb’s picture

robertwb CreditAttribution: robertwb commented
Status: Needs review » Active
robertwb’s picture

robertwb CreditAttribution: robertwb commented
Status: Active » Needs review
robertwb’s picture

robertwb CreditAttribution: robertwb commented
FileSize
2537190-17.patch938 bytes
2537190-17.patch938 bytes

This brings into line with the D8 login.

poker10’s picture

poker10 CreditAttribution: poker10 at ActivIT s.r.o. commented

Is there a reason why in the D8 patch was 'spellcheck' => 'false', and here is 'spellcheck' => 'none',? The 'spellcheck' => 'false', is still present in D9 codebase, so I suppose this is the correct one.

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton at Jeneration Web Development for Backdrop CMS commented
Status: Needs review » Needs work

Setting to NW based on the latest comment by @poker10 .