Closed (won't fix)
Project:
Global Redirect
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Anonymous (not verified)
Created:
9 Jul 2015 at 12:11 UTC
Updated:
19 Jan 2022 at 00:40 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Anonymous (not verified) commentedComment #2
Anonymous (not verified) commentedretesting
Comment #3
Anonymous (not verified) commentedComment #4
berdirThanks for the patch.
Might be possible to just no longer trim() the path that we have there?
Comment #5
berdirComment #6
Anonymous (not verified) commentedSure, I only did it to validate the format, but I guess it's safe to assume that the format is correct as it's not the module's job to valid it...
Added new patch...
Comment #7
Anonymous (not verified) commentedComment #8
Anonymous (not verified) commentedWhoops, seems you need to check the path isn't '/' when you de-slash a URI, to stop redirects on the homepage.
Comment #9
jhedstromThis should get tests passing.
Comment #10
jhedstromSorry for the array syntax changes, they make it look a little more complex of a change.
Comment #11
berdirI guess we''ll have to wait on #2532740: Fix incorrect config schema to land but this looks good to me.
Comment #12
berdirI've been testing this, globalredirectDeslash() fails on the frontpage because it results in an empty URL.
Comment #13
jhedstromThis adds a test and resolves the issue for deslashing the front page.
Comment #14
vimokkhadipa commentedI apply #13 patch. Work fine!
Comment #15
berdir#2548075: Globalredirect 8.x-1.x has been merged into redirect