Fix starterkits for 8.x

Expanded patch from #1 for LESS and SASS starter kits.

Also did some small tweaking in cdn starter kit.

I am not sure about the string which should we use for this kits, currently they are less.starterkit, sass.starterkit and cdn.starterkit. I guess that is fine.

Adding Bundle name to the drop-down will make it more clear for the user.

Not sure I understand what this exactly means?

Renaming the files (cdn.starterkit -> cdn.starterkit.info) is unnecessary.

Also, this issue really should not continue until this related issue is finished/fixed for 7.x (which is currently HEAD).

This really should just be an all encompassing issue/fix once the Drush support in 7.x has been finalized (i.e. it should mimic what is there, but in 8.x format).

@markcarver OK, we considering using D8 version in couple of projects, so that is why i started patching things. Will wait with this and will continue with other stuff.

@markcarver
I believe we should at least do the basics as @pivica is proposing, less changes to starterkit info file names. There is a number of reasons why this should happen now

1. but the primary reason is that Drupal 8 is nearing RC and people are considering it for new projects. 1 of the deterrents is shortage of Drupal 8 compatible base themes.
2. Bootstrap 8.x-3.x is not available for download from the project page which means the only people trying it out are developers who clone it from .git and this particular user group both expects and fixes bugs so there is no harm in starting with what we got at the moment.
3. I for one am eager to start several Drupal 8 projects and am a fan of Bootstrap theme so like @pivica I am making patches on my local projects as I go along which I am happy to contribute.

• @markcarverhttps://www.drupal.org/node/2261189 seems like it still has much left to do before its completed and depends on a number of child issues that still need their own resolution. Perhaps this issue should be separated as its own issue dealing primarily with releasing workable 8.x-3.x theme and starterkits

@pivica was definitely on the right track with his patches but missed a few tiny details before its a complete port to d8 so I added the missing bits.

1. template.php needed to be renamed to *.starterkit.theme
2. replaced logo.png with logo.svg
3. updated README.txt to refrence new .html.twig templates

I hope I didn't overlook anything and believe we now have a working copy of starterkits in 8.x-3.x that we can build and improve upon.

by the way @pivica I understand Serbian and would be happy to collaborate since we seem to be at similar d8 crossroads atm

@markcarver I totally understand your desire get this working via drush because in drupal 8 there is a little more involved in creating subthemes than just simple renaming of the .info file and I can definitely see basic drush commands becoming necessary even for most novice drupalers but there will always be people who will simply be too afraid to use drush so for them renaming starterkit files and variables will still be the only way to go. I'd be happy to contribute a guide if you like

I did not change the issue component from "Drush" to "Code" because I do believe final decision where the issue goes rests with the maintainers.

In any case, whilst this may be an interim solution, it is at least something that will work for the time being and Add Drush support for creating sub-themes looks like its going to take some time...

The patches provide a complete starterkits port from 7.x-3.x to 8.x-3.x so its not a complete waste even if its far from ideal solution you proposed.

Sorry comment form created a duplicate entry...

The last submitted patch, 6: add_fix_starterkits_for-2529840-6.patch, failed testing trying again...

The last submitted patch, 6: add_fix_starterkits_for-2529840-6.patch, failed testing trying again... Patch in #9 applies cleanly in my test environment ....

Lets try again...

Drupal 8 is nearing RC and people are considering it for new projects

That's core, not this project. This project's 8.x-3.x is not ready.

The patches provide a complete starterkits port from 7.x-3.x to 8.x-3.x

You cannot "port" something that does not fully exist yet. The 7.x-3.x branch isn't even "complete". Plain and simple.

I will say this again.... but in a different way:

The reason I'm "hesitant" about just going full force on 8.x-3.x is because it needs to stay in parity with the 7.x-3.x branch (as much as possible). These branches already diverge and that is why I brought on @neardark (to help facilitate this branch and keeping them in parity).

However, I have him assisting me with other issues right now and it also doesn't change the fact that 7.x-3.x is HEAD (master)..... not 8.x-3.x. Despite how core operates, this project currently "patches forward", not backwards. That will change once 8.x-3.x becomes HEAD, but until then... I'm not going to invest much in this branch right now while we have other (more pressing) issues to address.

There is a game plan in place with the maintainers of this project, but right now, 8.x-3.x isn't that much of a priority (as of yet, that will probably change in a couple months).

If anyone truly wants to "help" this project right now, they can help with
#2461607: Release 7.x-3.1.

Drupal 8 is RC now, I think it is the time to use bootstrap on D8.

If the maintainers are focused on D7 I think the best you can do is try to help them to have the parity that they want.

Hello,

here is my patch, just create template folder and put the files there.

Mark, no offense but for at least a year it says on the project page "It is strongly recommended to wait before using this branch or even creating issues regarding it.". It would be nice to know how much longer we should wait? Patches were suggested so why not make a first release?

I think if we had a version that contained at least proper starterkits more people like me (not yet familiar with D8 code) would be motivated to get started, learn the new mechanisms in D8 and ultimately help with this project.

EDIT: Since D8 is now officially announced for Nov 19, you think the pledge can be kept?

Actually, the entire Drush stuff is about to come out of the 7.x-3.x branch and put into a patch in #2261189: Add Drush support for creating sub-themes per the discussion @neardark and I have had recently. It's one of the last things that is holding up #2461607: Release 7.x-3.1 and we absolutely need to get that out.

Drush support is purely a feature; one that was never actually implemented or completed properly btw. It doesn't prevent people from still copying over the starterkits and following the manual instructions. We have a very clear idea of how we want to implement Drush support and much of it needs to be developed in a purely abstract way (committed code was literally borrowed from Omega's drush support and renamed).

As far as the 8.x-3.x branch itself:

While I haven't actually looked at it in a few months, my estimate has been that it's about 80-90% ported (barring any recent major theming breakage, which I haven't seen). @neardark and I are well aware of this new date and will likely be working a lot to get this release worthy. Patches are most certainly welcome (for other issues, not this one).

Edit: P.S. no offense, but I've been the biggest contributor to this project. Most people just open issues about why things aren't the way they want them. It's rare when we actually get a decent, committable patch... let alone a patch at all. We're all volunteers here (until a client pays for the development, which hasn't been the case for quite some time now).

Thank you for these explanations Mark. When I meant starter kits I was referring to those currently in the git-repository which are still not ported. I would be happy to have a downloadable release with the ported starter kits included (patch from #12 working for me) for the beginning. The Drush integration would be a bonus but I agree it doesn't have to be priority. So why don't commit #12?

Hm... I've always seen this issue as Drush related. I suppose that can change. You're correct in that the starterkits themselves will/should be in the release and definitely need to get fixed.

The patch in #16 is a complete addition, it doesn't actually "fix" existing code.

This issue should progress off of @Kristina Katalinic's work in #12 with the removal of the SASS starterkit (since it was removed until completed in 7.x-3.x). Setting to CNW.

I meant #12. I haven't actually applied #16. Sorry about that.

Just rerolled #12 patch (removed the sass part).

Oops, sorry, forgot to add new files in the patch.

Here they are.

I've credited @Kristina Katalinic as the author since she did the initial grunt work. Thanks!

I went ahead and made some cosmetic changes to the above patches while reviewing it. See commit for final details.

P.S. I didn't commit the README.txt changes as that will likely be fixed as part of #2466425: Update documentation.

@markcarver Thanks for the credit! So great to see we are moving forward with 8.x-3.x release especially now that Drupal 8.0.0 release has been announced. These are exciting time for Drupalers indeed :)