Closed (won't fix)
Project:
Bootstrap
Version:
8.x-4.x-dev
Component:
Drush
Priority:
Major
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
7 May 2014 at 16:50 UTC
Updated:
25 Mar 2019 at 12:30 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
markhalliwellComment #4
jcnventuraShouldn't this be marked as fixed?
Comment #5
markhalliwellNo, there is still much to do. The commits above was simply the groundwork for this.
Comment #6
markhalliwellComment #7
wundo commentedWhat is the status of the drush integration?
A description of what is missing here would come handy. Could you update this issue, Mark?
Comment #8
markhalliwellThis is a general idea of what needs to still happen. Most of it should be discussed in the child issues.
Comment #9
Daniel Schaefer commentedHow do I create a sub-theme on D8? The starterkits don't work.
Comment #11
markhalliwellPriority is being de-escalated so we can release 7.x-3.1.
Comment #13
macmladen commentedThis should be really high on priority list. There are many options, though, but
drushsubtheme building is a huge helper for both beginners and experienced developers.Sass and gulp based workflow would be more important to me, personally, but this is also nothing short of essential as well.
Comment #14
markhalliwellUnfortunately, it's not very high on the priority list right now.
Comment #15
joseph.olstadrefactored patch 10 due to readme.md changes in latest release 7.x-3.4 (or dev)
see patch
Comment #17
chandeepkhosa commentedWill creating a SASS subtheme with drush be available in Drupal 8?
Comment #18
twardnw commentedCan this be moved back up in priority?
Comment #19
joseph.olstadthis patch still applies cleanly on 7.x-3.7 , just tested it.
Comment #20
markhalliwellYes, now that 8.x-3.0 is out, let's bump up the priority.
Comment #21
heddnNot to disrupt things, but would you consider that using twig and drupal console might be an easier implementation? Liberty theme went that route and it seems fairly simple to get working.
Comment #22
markhalliwellDrupal Console is an entirely different beast and we'd likely need/want to support both.
Comment #23
markhalliwellI really do like the idea of making all the "templates" Twig though, since that's what they really are: templates.
It would be easier to implement both Drush and Drupal Console if we simply use the site's bootstraped instance and use the existing Twig service.
The only downside is 7.x support (which doesn't have Twig or class autoloading support for that matter).
That means there's two options for 7.x:
twig/twigincomposer.jsonand mention that if you wish to use Drush, you have to install bootstrap via composer?I'm kind of leaning towards the latter.
Comment #24
joseph.olstadLiberty theme? 5 sites currently report using this theme
To be honest, I wanted to get my theme done the fastest, easiest way possible doing what I learned similarly in other base themes. I ended up using the bootstrap theme as a base using this patch and the cdn option and rather than add a whole bunch of other dependencies and libraries I stuck to php and implemented the sassy / prepro modules and the phpsass library , adding the .scss file to my custom theme.info file and the .css file that it compiles. In production we disable the .scss and only use the compiled .css. It was bad enough trusting the cdn, which I noticed went down at least 3 times since we released our twitter bootstrap upgraded theme. I'd like to now get off the cdn and have a local copy of this stuff but haven't gotten around to it yet.
I like things easy and it seems like the cdn option and the sassy route was the easiest to implement for us.
I've seen some pretty complicated theming schemes using grunt and ndm and bower , so many extra dependencies outside of the drupal /php ecosystem kind of turned me off. played a bit with those tools to try them but I didn't see how it would benefit me.
adding twig, seeing as D8 uses that, it might be interesting to have this in D7 , however this would probably break compatibility with 3.x based subthemes would it not?
I haven't upgraded my biggest clients bootstrap since 3.5, their theme though is working well well. However I have another site to build though, so 3.7 sounds like a good starting point with this patch.
Comment #25
heddnre #24: I'm not suggesting that liberty is all that popular. I looked at it as a PoC theme to leverage twig templating to generate a sub-theme. I want the most popular theme in drupal to use that same approach, since it is so intuitive.
Comment #26
joseph.olstad@markcarver regarding your comment #23. twig for D7 sounds interesting. I didn't realize it was already available for D7 in a module called twig for D7 (tfd7).
Comment #27
markhalliwellNo, I was not referring to that module. I was specifically referring to utilizing the Symfony (
twig/twig) library to render the starterkit templates.The only reason Twig was mentioned was because it's an obvious choice to implement in 8.x.
We'd simply need to figure out a backport option for 7.x.
I'm still leaning towards a simple preg_replace option that simply mimics anything found inside
{{ ... }}brackets.Of course, if someone is using Twig and has it installed, we should probably default to that.
Comment #28
joseph.olstadpatch #15 still applies cleanly against 7.x-3.10
using it for a 'yet another' new project.
Comment #29
markhalliwellI'm really sorry that I haven't had a lot of time to focus on this issue like I'd have hoped. There's been a lot on my plate the past few months.
That being said, and the fact that there is existing documentation on how to create a sub-theme manually, this hasn't been huge on my list of priorities. The reality of this issue is that it's merely a "nice to have", it's not a real necessity (e.g. breaking functionality/code).
Comment #30
macmladen commentedIt is a bit confusing to have issue marked as 8.x-3.x-dev and to have patch working for 7.x-3.x, those should be separated I think.
We all must understand what amount of (probably unpaid) work goes in here for all parties and respect that.
@markcarver I just tried @joseph.olstad patch #15 and it worked (I tested both
bootstrap-subthemeandbootstrap-subtheme).As far as I can tell this works for 7.x-3.10 bootstrap and provide what I would expect.
This issue is 2.5 years old, offered solution (seems to me) is working and Drupal 7 is not current version.
I'd suggest accepting this solution for Drupal 7 version (or suggest to @joseph.olstad what should be improved to qualify it for inclusion), close this issue and open new one for Drupal 8 to avoid confusion which would deal with Drupal console, twig etc.
Comment #31
markhalliwellPlease read above comments. This project fixes HEAD first.
Comment #32
gpsloco commentedHi, I am sure this will make you laugh. But, as I barely know how to apply a patch to a module as in patch < file.patch, can someone please direct me to the answer for applying a patch, er, this patch to my version of drush? I use 8.1.10. Thank you so much!
Comment #33
joseph.olstad@gpsloco , the patch is not to patch drush, its to patch the module to add drush support . Drush support is done on the module level.
in this case:
patch -p1 < file.patchComment #34
markhalliwellNot sure this is going to happen for 8.x-3.x.
Also, I don't think this is ever going to happen for 7.x-3.x, especially if we go the Twig templating route. There's just no way we could get consistent support in 7.x given the lack of OO code.
Comment #35
joseph.olstadPatch 15 is still good as-is
If OO+ was end all be all drupal would have been written on Java using MVC as it was back in 2000/2001
Comment #36
markhalliwellSigh... that's not what I meant and did not want to start a "which OO platform is better" debate.
I just meant that the solution that I come up with (and have had in my head for a while actually) depends on a lot of classes/namespacing that just isn't very feasible in 7.x and older versions of Drush.
I don't want to have to maintain two (or more) Drush implementations.
Patch #15 isn't going in. Plain and simple.
Comment #37
markhalliwellStarterkits have been removed, see #2852156-4: Move "overrides" source files and generated CSS to separate project.