Inline form error reporting problems for the current password on the user profile form

Is the issue actually requiring a link or highlighting the current password field like the 'password' and 'confirm password' fields as shown in the image?

The error message also needs to be modified. The use of apostrophe makes it look weird.

The text "Your current password is missing or incorrect; it's required to change the Password" should be right under the "Current password" field (usually under the description actually).

This way the link from the "password" error at the top will go right to where it needs to be changed rather than 4 fields below where in is needed, when a user clicks on it.

It terms of visual grouping and best practices, the "Current Password" field should be right above the fields where you set your new password. At least this is how most websites handle changing password functionality.

project Password tab D7 makes core act this way. of course, It would be more ideal UX/UI pattern as /user/%/edit page is busy, to say. Otherwise wrapping these 3 fields in a fieldset would as least visual group them.

just realized, password entry is needed for changing email too. Again, it's a busy little page.

@mgifford
i've delt with this by altering the User Module itself by reworking how the validation process senses errors. I don't think anythings wrong with the IFE module, as such.. but the way the actual form is building errors.

other touchups this includes

• wrapping change password with fieldset
• moving description up to top of fieldset (now a paragraph on top) which also leaves the javascript response for matching more readable.
• wrapping both the account status and Roles into a collapsible details
• weighting the Username and Email to the top of all items.

my comment about the password tabs, was just a comment. certainly i'm not going to try to alter anything that much.

had attached same image twice.

this resets one phase i shouldn't have touched.

removing summary 'Data model changes' images from comment 6

sorry #15 had typo. also corrects label uppercasing to match

down-stepping status for now.

labels sorted out. new screen shots attached.

umm.
in relation to original issue 2455933 and mikes comment#8 . I've just realized they remade the ticket toward different subsystem. My patch should be against the org ticket.

from what i currently best understand:
This AccountFrom (in User module) isn't just a 'normal drupal form' (certainly its not a form plugin) -- it is ContentEntityForm and ties into a Validation Constraint. So my patch simply adds in a routine during it's flagValidation to rework the messages and adds in the Current Password field to be now marked as 'in error' and reworks messages..

To the point regarding FAPI, its true that fields do not have a property to notify that another child field should be triggered as an error during validation. And possibly then, a property to hold that special error message.

I would agree that it would be nice have FAPI have the ability, but this is as much a use case for forms that have more complex validation tie backs.

a follow up thought:

• (in general) the interaction with #states
• giving this originates from the /user forms. this error does have 2 fields that can act against it: the password field & email field both can trigger error on Current Password (formatPlural instances from parent errors)

in good conscience, i'm reattaching patch to 2455933.

Patch no longer applies to 8.1.

Chasing UserAccountFormFieldsTest.php

https://api.drupal.org/api/drupal/core!modules!user!tests!src!Kernel!Use...

@dmsmidt, should you get here..
please over this issue, look at #2455933: Error highlighting and reporting problems for the current password on the user profile form that patch is more current to this one. they are one in the same

Let's mark this as a duplicate for now then of #2455933: Error highlighting and reporting problems for the current password on the user profile form

Just cleaning up a bit.

Fixing the tag.