Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
contact.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
29 Jun 2015 at 03:27 UTC
Updated:
22 Jul 2015 at 16:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
tim-e commented+1. Although I would like to continue on, in reality I don't have the time to do so.
Comment #2
jibran+1 to the idea. I have also helped with https://www.drupal.org/project/contact_storage in contrib as well.
Comment #3
larowlanThanks Tim - if things change - still happy to help
Comment #4
jibranThanks @tim-e.
Comment #5
pameeela commentedComment #6
kattekrab commentedstraightforward 1 line patch.
I'd RTBC - but perhaps we should wait to hear from @andypost first?
Comment #8
pameeela commentedOK so I didn't pull before I did the patch :) Who knew there were so many changes to maintainers.txt!
Comment #9
andypost+1 on mention me as maintainer because I'm anyway on it ;)
Comment #10
naveenvalechasmall nitpick.
Comment #11
jibranThat's great @andypost.
Comment #12
xjmThanks @jibran and @andypost for volunteering for this! Can you both add some links to your work on the module up to now, and also confirm that you can commit to the responsibilities described in http://cgit.drupalcode.org/governance/plain/drupal-core.html for subsystem maintainers?
Once we have that, we can re-RTBC this and assign it to Dries. Both @andypost and @jibran have done great ongoing work in Drupal 8 overall.
Also thanks @tim-e for your previous contributions.
Comment #13
andypost@xjm suppose better to grep commits with
Comment #14
jibran@xjm and these are my and andypost's contributions to the issue queue of contact module.
As a maintainer of shortcut module I'm aware of these responsibilities and yes I can commit to those. @andypost is also the maintainer of comment and history module and by looking at his work in the contact module issue queue I think he is aware of it and has been doing this for a while.
Comment #15
kattekrab commentedNice. RTBC!
\o/
Comment #16
kattekrab commentedComment #17
xjmThanks @jibran and @andypost!
(Note that the links in #14 are not actually contributions to the module, just issues that are followed. E.g. #2362519: Remove dead code from contact.install is listed but has no comments from either of our new maintainers. :) Which is why I meant to suggest linking a couple specific issues since d.o no longer supports a view for it. But @andypost's grep shows it clearly.)
Assigning to Dries for review. Thanks for adopting another module.
Comment #18
dries commentedThis looks great to me! Thank you tim-e, jibran and andypost.