Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Reporter:
Anonymous (not verified)
Created:
27 Jun 2015 at 08:19 UTC
Updated:
19 Dec 2016 at 03:54 UTC
Jump to comment: Most recent
Comments
Comment #1
Anonymous (not verified) commentedComment #2
PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
Anonymous (not verified) commentedComment #4
Anonymous (not verified) commentedComment #5
Anonymous (not verified) commentedComment #6
Anonymous (not verified) commentedComment #7
Anonymous (not verified) commentedComment #8
Anonymous (not verified) commentedComment #9
Anonymous (not verified) commentedComment #10
Anonymous (not verified) commentedComment #11
Anonymous (not verified) commentedComment #12
Anonymous (not verified) commentedComment #13
ajalan065 commentedHi Lwin Kyaw Myat,
1. Please remove CHANGELOG.txt from your project.
2. Follow the guidelines for in-project documentation and/or the README template.
3. You have given inline css in your .module file.
Instead, create a separate css file, and give the css details in it and apply it wherever needed.
4. Do not put entire stuff in a single function.
Instead put the switch-case in a separate function and call it if required.
Manual Review
1. Individual user account
Yes: Follows the guidelines for individual user accounts.
2. 3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
3. Secure Code
Yes: Meets the security requirements.
4. Code long/complex enough for review
No: Does not follow the guidelines for project length and complexity.
Your PAReview: review bonus tag is being removed,(This will be done only once.) Please follow the Workflow to get back the tag again.
Comment #14
Anonymous (not verified) commentedHi ajalan065,
All is worked.
1.removed CHANGELOG.txt
2.Changed READMED.txt
3.Changed .module
4.Remove switch-case in .module file
Comment #15
ajalan065 commentedHi Lwin Kyaw Myat,
The module is fine. But I am not able to get the difference visible on various fonts. Can you please attach screenshots?
Comment #16
Anonymous (not verified) commented