This module is myanmar web font embedding from http://mmwebfonts.comquas.com/

How it work

This module will add MMWebFonts link at the header of the site.

Sandbox Link

https://www.drupal.org/sandbox/mglwinkyawmyat/2512772

Repository Link

http://cgit.drupalcode.org/sandbox-mglwinkyawmyat-2512772

Clone Repo

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/mglwinkyawmyat/2512772.git mmwebfonts

Result of Pareview.sh

http://pareview.sh/pareview/httpgitdrupalorgsandboxmglwinkyawmyat2512772git

Manual review of other projects

https://www.drupal.org/node/2513220#comment-10064338
https://www.drupal.org/node/2500371#comment-10064608
https://www.drupal.org/node/2215325#comment-10064654

Comments

Anonymous’s picture

Project: » Drupal.org security advisory coverage applications
Component: Code » module
PA robot’s picture

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Anonymous’s picture

Status: Needs review » Needs work
Anonymous’s picture

Status: Needs work » Reviewed & tested by the community
Anonymous’s picture

Status: Reviewed & tested by the community » Needs review
Anonymous’s picture

Issue summary: View changes
Anonymous’s picture

Issue summary: View changes
Anonymous’s picture

Priority: Normal » Critical
Anonymous’s picture

Assigned: » Unassigned
Anonymous’s picture

Priority: Critical » Normal
Issue summary: View changes
Anonymous’s picture

Issue summary: View changes
Anonymous’s picture

Issue summary: View changes
Issue tags: +PAreview: review bonus
ajalan065’s picture

Status: Needs review » Needs work
Issue tags: -PAreview: review bonus

Hi Lwin Kyaw Myat,

1. Please remove CHANGELOG.txt from your project.

2. Follow the guidelines for in-project documentation and/or the README template.

3. You have given inline css in your .module file.
Instead, create a separate css file, and give the css details in it and apply it wherever needed.

4. Do not put entire stuff in a single function.
Instead put the switch-case in a separate function and call it if required.


Manual Review


1. Individual user account
Yes: Follows the guidelines for individual user accounts.

2. 3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.

3. Secure Code
Yes: Meets the security requirements.

4. Code long/complex enough for review
No: Does not follow the guidelines for project length and complexity.

Your PAReview: review bonus tag is being removed,(This will be done only once.) Please follow the Workflow to get back the tag again.

Anonymous’s picture

Status: Needs work » Needs review

Hi ajalan065,
All is worked.
1.removed CHANGELOG.txt
2.Changed READMED.txt
3.Changed .module
4.Remove switch-case in .module file

ajalan065’s picture

Hi Lwin Kyaw Myat,
The module is fine. But I am not able to get the difference visible on various fonts. Can you please attach screenshots?

Anonymous’s picture

Priority: Normal » Minor
Status: Needs review » Closed (won't fix)