There are some issues with Views Slideshow when running PHP 5.4 or newer:

  • Strict warning: Declaration of views_slideshow_plugin_style_slideshow::options_validate() should be compatible with views_plugin::options_validate($form, &$form_state) in views_include_handler() (line 98 of sites/all/modules/contrib/views/includes/handlers.inc).
CommentFileSizeAuthor
#3 php_compatibility-2512896-3.patch657 bytesbalis_m
#2 views_slideshow-n2512896-2.patch2.96 KBmichelle
#1 views_slideshow-n2512896-1.patch563 bytesdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new views_slideshow-n2512896-1.patch563 bytes

This should do it.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
StatusFileSize
new views_slideshow-n2512896-2.patch2.96 KB

I made a D6 version of the change in #1872616: PHP 5.4.x: "preg_replace() /e modifier is deprecated, use preg_replace_callback()" and also fixed this issue when it came up because I had completely forgotten about this issue. When I went to apply it to the client's code, which was already patched, I was reminded of this issue. :) So I am moving my patch, which also contains this patch, over here.

balis_m’s picture

balis_m commented
StatusFileSize
new php_compatibility-2512896-3.patch657 bytes

I' ve created the patch of #1, to be compatible with latest 6.x-2.x-dev

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Just to be clear:

osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented
Related issues: +#2411093: PHP strict warnings: Declaration of ... should be compatible with ...

The changes to function options_validate(&$form, &$form_state) may not be necessary, see #52 of the related views issue.

  • NickWilde committed 0013cf1 on 6.x-3.x 
    Issue #2512896 by DamienMcKenna, Michelle, balis_m: PHP 5.4+...

  • NickWilde committed 45214f4 on 6.x-2.x authored by balis_m 
    Issue #2512896 by DamienMcKenna, Michelle, balis_m: PHP 5.4+...
nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Needs review » Fixed

Mostly applied to both 6.x-2.x and 6.x-3.x, thanks for the patches. Only a year for some of it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.