Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
There are some issues with Views Slideshow when running PHP 5.4 or newer:
- Strict warning: Declaration of views_slideshow_plugin_style_slideshow::options_validate() should be compatible with views_plugin::options_validate($form, &$form_state) in views_include_handler() (line 98 of sites/all/modules/contrib/views/includes/handlers.inc).
Comment | File | Size | Author |
---|---|---|---|
#3 | php_compatibility-2512896-3.patch | 657 bytes | balis_m |
#2 | views_slideshow-n2512896-2.patch | 2.96 KB | Michelle |
#1 | views_slideshow-n2512896-1.patch | 563 bytes | DamienMcKenna |
Comments
Comment #1
DamienMcKennaThis should do it.
Comment #2
MichelleI made a D6 version of the change in #1872616: PHP 5.4.x: "preg_replace() /e modifier is deprecated, use preg_replace_callback()" and also fixed this issue when it came up because I had completely forgotten about this issue. When I went to apply it to the client's code, which was already patched, I was reminded of this issue. :) So I am moving my patch, which also contains this patch, over here.
Comment #3
balis_m CreditAttribution: balis_m commentedI' ve created the patch of #1, to be compatible with latest 6.x-2.x-dev
Comment #4
DamienMcKennaJust to be clear:
Comment #5
osopolarThe changes to function
options_validate(&$form, &$form_state)
may not be necessary, see #52 of the related views issue.Comment #8
NickDickinsonWildeMostly applied to both 6.x-2.x and 6.x-3.x, thanks for the patches. Only a year for some of it.