Problem/Motivation

Right now there is lots of regions being used in the Classy. To make it more usable for the end-user, it might be good to have less regions. Also lots of the regions are very specific (e.g tabs or actions) and they are meant to only print single block.

Proposed resolution

Figure out which regions could be removed and merged to something else by making them less specific.

Remaining tasks

-

User interface changes

-

API changes

-

Data model changes

-

Comments

Wim Leers’s picture

Title: Clean up regions in Classy » Clean up regions in Classy & Bartik
Priority: Normal » Major
Issue tags: +DX (Developer Experience), +TX (Themer Experience)

At least also Bartik. See #507488-238: Convert page elements (local tasks, actions) into blocks.1. Likely all themes' page.html.twig templates.

mortendk’s picture

Assigned: Unassigned » mortendk

yes theres a bunch of "wrapper" regions & blocks before you even get to the content - im gonna look into a way we could do this. Maybe we could solve this by having a "cleanup" folder in classy and drop in those templates with no wrappers in ?

davidhernandez’s picture

I think maybe we should postpone this. We need to wait and see what the fallout is from converting the page variables to blocks and renaming the menu regions.

emma.maria’s picture

Yes we should focus efforts on those two issues. They are very almost there and higher priority right now.

#507488: Convert page elements (local tasks, actions) into blocks
#2005546: Use branding block in place of page template branding variables (site name, slogan, site logo)
#2513526: Rename the menu regions

The bottom two need upgrade paths.

Jeff Burnz’s picture

I was going to open a new issue but this one seems appropriate - page.highlighted is in Classy's page template twice, this I assume is a bug.

LewisNyman’s picture

Shouldn't split this issue? Classy is frozen until 9.x and we can't mess with the regions. Bartik is unfrozen and could have these inprovements in 8.1

mortendk’s picture

yup think that make sense + i wanna do a classy 2 now so we can play with a updated version of classy, as its frozen (let it go) ...

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Feuerwagen’s picture

I vote for closing this (as won't fix):

- In general it's still valid, but not sure if anyone will ever tackle this, given the legacy state of these themes (in Drupal 10).
- It would need to be split into two tickets for the two themes in contrib (for Drupal 10).
- No activity or visible traction for seven years, so this doesn't seem to be this big of a problem (even in the past with wide(r) use of those themes).

Wim Leers’s picture

Assigned: mortendk » lauriii
Status: Active » Reviewed & tested by the community
Issue tags: +Needs frontend framework manager review

@Feuerwagen makes excellent points. 😊

Assigning to the front end framework manager for confirmation, so they can mark it Closed (won't fix).

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

bnjmnm’s picture

Assigned: lauriii » Unassigned
Status: Reviewed & tested by the community » Closed (won't fix)

I'm going to make the call as a provisional FEFM and Closed (won't fix) this. The points @Feuerwagen made in #19 are good ones. I'll build on that with a few additional ones:

  • This would either be a disruptive change, or one that requires significant effort to ensure it isn't disruptive to existing sites using Classy and Bartik. It would be difficult to justify this kind of disruption for sites using these legacy themes, especially because one of the reasons to continue their use is to avoid the disruption of changing the theme
  • While it's technically true that this is still an open issue that should be transferred to the now-contrib themes it references, the limited activity and follower count since this issue was created 7 years ago suggests this is a low priority concern. This is an opportunity to let a low traction issue organically depart our crowded queue. Filing new issues to strictly adhere to the process creates unnecessary noise. If there is renewed interest in such efforts, new issues can be filed in contrib Classy/Bartik from those who are interested.