Problem/Motivation
Right now there is lots of regions being used in the Classy. To make it more usable for the end-user, it might be good to have less regions. Also lots of the regions are very specific (e.g tabs or actions) and they are meant to only print single block.
Proposed resolution
Figure out which regions could be removed and merged to something else by making them less specific.
Remaining tasks
-
User interface changes
-
API changes
-
Data model changes
-
Comments
Comment #1
Wim LeersAt least also Bartik. See #507488-238: Convert page elements (local tasks, actions) into blocks.1. Likely all themes'
page.html.twig
templates.Comment #2
mortendk CreditAttribution: mortendk as a volunteer commentedyes theres a bunch of "wrapper" regions & blocks before you even get to the content - im gonna look into a way we could do this. Maybe we could solve this by having a "cleanup" folder in classy and drop in those templates with no wrappers in ?
Comment #3
davidhernandezI think maybe we should postpone this. We need to wait and see what the fallout is from converting the page variables to blocks and renaming the menu regions.
Comment #4
emma.mariaYes we should focus efforts on those two issues. They are very almost there and higher priority right now.
#507488: Convert page elements (local tasks, actions) into blocks
#2005546: Use branding block in place of page template branding variables (site name, slogan, site logo)
#2513526: Rename the menu regions
The bottom two need upgrade paths.
Comment #5
Jeff Burnz CreditAttribution: Jeff Burnz commentedI was going to open a new issue but this one seems appropriate -
page.highlighted
is in Classy's page template twice, this I assume is a bug.Comment #6
LewisNyman CreditAttribution: LewisNyman at Wunder commentedShouldn't split this issue? Classy is frozen until 9.x and we can't mess with the regions. Bartik is unfrozen and could have these inprovements in 8.1
Comment #7
mortendk CreditAttribution: mortendk as a volunteer commentedyup think that make sense + i wanna do a classy 2 now so we can play with a updated version of classy, as its frozen (let it go) ...
Comment #19
FeuerwagenI vote for closing this (as won't fix):
- In general it's still valid, but not sure if anyone will ever tackle this, given the legacy state of these themes (in Drupal 10).
- It would need to be split into two tickets for the two themes in contrib (for Drupal 10).
- No activity or visible traction for seven years, so this doesn't seem to be this big of a problem (even in the past with wide(r) use of those themes).
Comment #20
Wim Leers@Feuerwagen makes excellent points. 😊
Assigning to the front end framework manager for confirmation, so they can mark it
.Comment #22
bnjmnmI'm going to make the call as a provisional FEFM and Closed (won't fix) this. The points @Feuerwagen made in #19 are good ones. I'll build on that with a few additional ones: