Coming from #2469219: Remove the Generic Entity Processor it's too easy to get into a circular dependency trying to get plugin definitions from a plugin.

This fixes that. Should be backwards compatible since no one should be overriding FeedsPlugin::__construct().instance

CommentFileSizeAuthor
#6 feeds-FeedsPlugin-pass-definition-2497507-6.patch2.05 KBtwistor
#5 feeds-FeedsPlugin-pass-definition-2497507-5.patch1.66 KBtwistor
#1 feeds-FeedsPlugin-pass-definition-2497507-1.patch3.15 KBtwistor

Comments

twistor’s picture

twistor commented
Status: Active » Needs review
StatusFileSize
new feeds-FeedsPlugin-pass-definition-2497507-1.patch3.15 KB
twistor’s picture

twistor commented
Priority: Normal » Major

  • twistor committed ede61cb on 7.x-2.x 
    Issue #2497507 by twistor: Pass plugin definition to FeedsPlugin objects
twistor’s picture

twistor commented
Status: Needs review » Fixed
twistor’s picture

twistor commented
Issue summary: View changes
Status: Fixed » Needs review
StatusFileSize
new feeds-FeedsPlugin-pass-definition-2497507-5.patch1.66 KB

Ok, overriding the constructor isn't a good idea.

twistor’s picture

twistor commented
StatusFileSize
new feeds-FeedsPlugin-pass-definition-2497507-6.patch2.05 KB

Found another circular dependency in FeedsEntityProcessor.

  • twistor committed 79918b8 on 7.x-2.x 
    Issue #2497507 by twistor: Pass plugin definition to FeedsPlugin objects
twistor’s picture

twistor commented
Assigned: twistor » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.