getComponentNames must be of the type array

Try the attached.

Patch solves this issue!
Just did a clean install with latest beta and installed latest dev of features. Ran into the same problem, which is gone after the patch was applied.

And as mokone91 mentioned (at the same minute), there's still a few places with the same/similar problem.

Thanks for the draft patch.

The change that triggers this bug was this commit for #1081266: Avoid re-scanning module directory when a filename or a module is missing. Specifically, the patch changed the arguments to ExtensionInstallStorage::getComponentNames().

-   * @param string $type
-   *   Type of components: 'module' | 'theme' | 'profile'
-   * @param array $list
-   *   Array of theme or module names.
+   * @param \Drupal\Core\Extension\Extension[] $list
+   *   An associative array of Extension objects, keyed by extension name.

We call this method in two places. First, in FeaturesInstallStorage.php, we override two methods of ExtensionInstallStorage, and in each case we call getComponentNames(). This is what @benjy has addressed, adapting the relevant sections from the patch that introduced these changes.

The second is in FeaturesManager::listExtensionConfig(), which is what is triggering the remaining bug. It looks straightforward to address; the method already receives an Extension object as an argument.

Here's a patch to update usage of ExtensionInstallStorage::getComponentNames().

I'm still seeing the following error with patch #6 which I think relates to the call in FeaturesManager::listExtensionConfig()?

Recoverable fatal error: Argument 1 passed to Drupal\Core\Config\InstallStorage::getComponentFolder() must be an instance of Drupal\Core\Extension\Extension, string given, called in /core/lib/Drupal/Core/Config/InstallStorage.php on line 202 and defined in Drupal\Core\Config\InstallStorage->getComponentFolder() (line 241 of core/lib/Drupal/Core/Config/InstallStorage.php).

I can confirm that it works. Rerolled.

To reproduce the last change from #6 you can use "drush fd MY_CUSTOM_MODULE" for example, and the method listExtensionConfig() will be executed. Also you can debug with xdebug and drush.

Should we start covering with some tests ?

Added

+bundle:
+  settings: []

See #2505787: Bundle settings is null, not array for FeatureBundleInterface::setSettings

thanks guys :)

Thanks! Applied the fix from #6, as the settings array is fixed in #2505787: Bundle settings is null, not array for FeatureBundleInterface::setSettings.