[D7] Halloumi

Made changes to the issue summary and the issue title

There are few errors are still in the code.

FILE: /var/www/drupal-7-pareview/pareview_temp/halloumi.module
--------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------
2 | ERROR | [x] You must use "/**" style comments for a file comment
3 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found 0
4 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found 0
5 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found 0
22 | ERROR | [x] Expected 1 space(s) before asterisk; 0 found
22 | ERROR | [x] Doc comment short description must end with a full stop
23 | ERROR | [x] Expected 1 space(s) before asterisk; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/README.txt
-----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-----------------------------------------------------------------------
1 | WARNING | [ ] Line exceeds 80 characters; contains 120 characters
5 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/halloumi.info
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
4 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Automated Review

You have a few problems here, nothing to crazy. http://pareview.sh/pareview/httpgitdrupalorgsandboxstevencrichton2496977git

Manual Review

README.txt/README.md

Your README.txt does not match the suggested guidlines, see the template https://www.drupal.org/node/2181737

Code long/complex enough for review

Your code does not meet the guidelines on suggested length/complexity. It is recommended to have at least 120 line and 5 functions.
https://groups.drupal.org/node/195848

Coding style & Drupal API usage

Your code works as expected.

I appreciate you maybe going for something lightweight and simple however what you have done does not show the requirements mentioned in https://groups.drupal.org/node/195848. If you want to increase the size of the project maybe you could like at adding in a feature to change the required url of /halloumi to a choice made by the user. You could create a setting section for this and integrate with https://www.drupal.org/project/pathauto see http://www.drupalcontrib.org/api/drupal/contributions!pathauto!pathauto.....

However it does say:

This does not mean that short projects will never get approved, a git admin can promote a project on behalf of the user without giving the git vetted user role to them.

So you could go down that route once the other minor changes are made.

Hi stevencrichton,

Seems I was posting while others where. If you have PHP_CodeSniffer (https://github.com/squizlabs/PHP_CodeSniffer) installed on you machine then you could make the changes using the command phpcbf. However it will be quicker to make the changes manually and then check it with http://pareview.sh.

Hi stevencrichton,

I do like the sound of it. I also noticed a comment which says the length will be okay https://www.drupal.org/node/2316793#comment-9037065

They only thing you will miss out on is the git vetted user role which you can get latter. However I would let someone else have the final say since I am still new to the procedures.

I did notice a few minors issues still there at http://pareview.sh/pareview/httpgitdrupalorgsandboxstevencrichton2496977git.

/halloumi.module
1. A full stop is needed after Apps in the @file
2. Only one blank line is needed before your hook_menu()

/README.txt
1. There is a preference to 80 character per line as a max.
2. You need a newline at the end of the file like the halloumi.module has.

/halloumi.info
1. Same here for the newline at the end of the file.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi Steven,
I did a manual review of the module. Your contribution is appreciated.

In the hook_menu implementation, the type of the menu router item needs to be MENU_CALLBACK (because it's a top level menu item and this module or any other module does not define a parent router item).

Also, call drupal_exit() after the drupal_json_output() call to ensure session data and other shutdown handlers are taken care of.

Thanks for your contribution!

I've promoted this project from a sandbox to a full project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.