If a user selects an item in a select list and then uses the tab key on the keyboard to move to the select/remove arrows, there is no visual que that the arrow is now in focus.

This little patch puts the same effect on :focus as is there on :hover

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

markconroy’s picture

markconroy’s picture

Title: Add visual que for :focus state for keybord users » Add visual que for :focus state for keyboard users
markconroy’s picture

Status: Active » Needs review
mgifford’s picture

Issue tags: +keyboard focus

Looks fine from an accessibility point of view.

You shouldn't have this fragment in the patch though @@ -85,4 +85,4

best to remove it and keep with the css changes adding focus behaviour. Very minor change and then it should be good to go.

markconroy’s picture

Hi Mike,

Thanks a lot for that. I've removed the "@@ -85,4 +85,4" parts, but not sure why. They were automatically created when I created the patch using these instructions:
https://www.drupal.org/node/707484

Attached.

mgifford’s picture

Your editor might be adding or removing a line when editing the file. That's the best I can think of for why that would happen.

markconroy’s picture

Mike,

Looking at other patches, here for example: https://www.drupal.org/node/1321732#comment-7044900

Those characters are also left in. Perhaps it's a feature of git more so than my editor?

attheshow’s picture

Status: Needs review » Fixed

Fixed in 7.11. Thanks everyone!

  • markconroy authored 129691f on 7.x-1.x
    Issue #2496605 by markconroy: Add visual que for :focus state for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.