Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
If a user selects an item in a select list and then uses the tab
key on the keyboard to move to the select/remove arrows, there is no visual que that the arrow is now in focus.
This little patch puts the same effect on :focus as is there on :hover
Comment | File | Size | Author |
---|---|---|---|
#5 | multiselect-keyboard-focus-for-add-remove-2496605-5.patch | 892 bytes | markconroy |
#1 | multiselect-keyboard-focus-for-add-remove-2496605-1.patch | 928 bytes | markconroy |
multiselect-keyboard-focus.png | 9.08 KB | markconroy |
Comments
Comment #1
markconroy CreditAttribution: markconroy at Annertech commentedAttaching patch.
Comment #2
markconroy CreditAttribution: markconroy at Annertech commentedComment #3
markconroy CreditAttribution: markconroy at Annertech commentedComment #4
mgiffordLooks fine from an accessibility point of view.
You shouldn't have this fragment in the patch though @@ -85,4 +85,4
best to remove it and keep with the css changes adding focus behaviour. Very minor change and then it should be good to go.
Comment #5
markconroy CreditAttribution: markconroy at Annertech commentedHi Mike,
Thanks a lot for that. I've removed the "@@ -85,4 +85,4" parts, but not sure why. They were automatically created when I created the patch using these instructions:
https://www.drupal.org/node/707484
Attached.
Comment #6
mgiffordYour editor might be adding or removing a line when editing the file. That's the best I can think of for why that would happen.
Comment #7
markconroy CreditAttribution: markconroy at Annertech commentedMike,
Looking at other patches, here for example: https://www.drupal.org/node/1321732#comment-7044900
Those characters are also left in. Perhaps it's a feature of git more so than my editor?
Comment #8
attheshow CreditAttribution: attheshow commentedFixed in 7.11. Thanks everyone!